Replace system.network.state with network.connection.state#1632
Merged
jsuereth merged 9 commits intoopen-telemetry:mainfrom Dec 17, 2024
Merged
Replace system.network.state with network.connection.state#1632jsuereth merged 9 commits intoopen-telemetry:mainfrom
jsuereth merged 9 commits intoopen-telemetry:mainfrom
Conversation
ChrsMark
force-pushed
the
fix_system_net_state
branch
from
ba65c2c to
20e087c
Compare
mx-psi
approved these changes
Nov 29, 2024
braydonk
approved these changes
Nov 29, 2024
dmitryax
approved these changes
Nov 30, 2024
Member
Author
|
@AlexanderWert @open-telemetry/specs-semconv-maintainers that should be good to go? |
lmolkova
reviewed
Dec 3, 2024
Member
lmolkova
left a comment
lmolkova
left a comment
There was a problem hiding this comment.
Looks good, left a few suggestions to clean up old enum members
5 tasks
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
ChrsMark
force-pushed
the
fix_system_net_state
branch
from
9e6babe to
576493a
Compare
Signed-off-by: ChrsMark <[email protected]>
Member
Author
mx-psi
approved these changes
Dec 13, 2024
Member
|
tagging @open-telemetry/semconv-security-approvers in case they want to take a look |
trisch-me
reviewed
Dec 16, 2024
trisch-me
reviewed
Dec 16, 2024
Co-authored-by: Alexandra Konrad <[email protected]>
trisch-me
approved these changes
Dec 17, 2024
Contributor
|
@ChrsMark I think one test is failing, otherwise good to go! |
Signed-off-by: ChrsMark <[email protected]>
braydonk
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #308
Changes
ref: #308 (comment)
Merge requirement checklist
[chore]