Fix typo in schemas for messaging attribute changes#1595
Merged
lmolkova merged 4 commits intoopen-telemetry:mainfrom Nov 26, 2024
Merged
Fix typo in schemas for messaging attribute changes#1595lmolkova merged 4 commits intoopen-telemetry:mainfrom
lmolkova merged 4 commits intoopen-telemetry:mainfrom
Conversation
JamieDanielson
requested review from
a team and
tigrannajaryan
as code owners
2 tasks
Member
|
it seems we should not update old schemas - semantic-conventions/CONTRIBUTING.md Lines 140 to 141 in c5093dd I'd like to stop producing/updating these files manually - #1596. Curious what brought your attention to these files, @JamieDanielson ? Do you happen to use them in any way? |
Member
Author
We were updating our semantic conventions package in JS and wanted to make sure we captured the breaking changes since we also recently updated our build script. I just happened to notice the typo in the 0.28 schema file and put up a PR to fix it. We don't use this attribute anywhere as far as I can tell. |
lmolkova
reviewed
Nov 25, 2024
trask
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
While reviewing recent semantic convention changes, I noticed these typos for messaging changes.
Merge requirement checklist
[chore]