Don't capture db.operation.name and db.collection.name from query formats that support multiples#1566
Merged
lmolkova merged 11 commits intoopen-telemetry:mainfrom Nov 25, 2024
Conversation
c4e26d6 to
4fd09f2
Compare
db.operation.name and db.collection.name from query formats that support multiples
4fd09f2 to
514e388
Compare
d2b3fb2 to
70ed3de
Compare
70ed3de to
c4db43a
Compare
This was referenced Nov 10, 2024
lmolkova
reviewed
Nov 11, 2024
lmolkova
reviewed
Nov 11, 2024
lmolkova
reviewed
Nov 19, 2024
lmolkova
approved these changes
Nov 19, 2024
maryliag
approved these changes
Nov 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't capture
db.operation.nameanddb.collection.namefrom query formats that support multiples.The reason behind this change is that it could be confusing to have
db.operation.nameanddb.collection.namecaptured for some SQL operations but not for other SQL operations, also leading to an inconsistent experience in SQL metrics.And these parsed values (single or multiple) are now present in
db.query.summary, so the loss of information seems minimal.Specifically,
db.operation.nameis changed from:to:
and
db.collection.nameis changed from:to: