Add network.interface.name attribute#1492
Conversation
ac2123c to
641844d
Compare
It can, you can list the metrics that are affected and the attribute change. See for example: https://github.com/open-telemetry/semantic-conventions/blob/main/schemas/1.28.0#L48 |
joaopgrassi
left a comment
There was a problem hiding this comment.
Please also add the old attribute to the deprecated file, like https://github.com/open-telemetry/semantic-conventions/blob/main/model/database/deprecated/registry-deprecated.yaml
|
Thank's @joaopgrassi . My concern here is that |
I believe yes, each "area" now has its own deprecated file, so within that usage, the attribute is considered deprecated. There then it's also mentioned which one to use instead. @lmolkova @jsuereth is this correct in your view? Not sure if we had such case before 🤔 |
06ed333 to
97552c3
Compare
Appears that we can't model this right now? I get: > make fix
Diagnostic report:
× The attribute id `system.device` is declared multiple times in the
│ following groups:
│ ["registry.container.metrics.deprecated",
│ "registry.system.metrics.deprecated", "registry.system"]
/cc @joaopgrassi |
lmolkova
left a comment
There was a problem hiding this comment.
LGTM (with some minor suggestions to make CI happy)
There is no need to deprecate attributes if it's still used. The only thing you need to do is to write the proper section in the schema-next (which you already did!) |
3bf1711 to
ff3f5df
Compare
|
@open-telemetry/semconv-system-approvers could you review this one please ? |
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
190d9a2 to
14ee552
Compare
Changes
ref: #308 (comment)
As discussed in the above referenced issue, this PR introduces the
network.interface.nameattribute and replace with it thesystem.deviceattribute of system and container network metrics.Note: I'm not sure if this change can be reflected in
schema-next.yaml🤔 .Merge requirement checklist
[chore]