DB: fix how operation and collection names are recorded for complex queries (opt-in db.query.text on metrics, new db.query.summary recommended attribute)#1482
Merged
lmolkova merged 19 commits intoopen-telemetry:mainfrom Oct 18, 2024
Conversation
lmolkova
commented
Oct 16, 2024
db.query.text on DB client duration metricdb.query.text on metrics, new db.query.synthetic recommended attribute)
trask
reviewed
Oct 16, 2024
trask
reviewed
Oct 16, 2024
trask
reviewed
Oct 16, 2024
trask
reviewed
Oct 16, 2024
lmolkova
commented
Oct 16, 2024
Member
|
some possibilities for naming:
|
Member
Author
|
I really like the |
trask
reviewed
Oct 16, 2024
db.query.text on metrics, new db.query.synthetic recommended attribute)db.query.text on metrics, new db.query.summary recommended attribute)
c27b092 to
004a94d
Compare
004a94d to
9fb01e2
Compare
trask
reviewed
Oct 16, 2024
maryliag
reviewed
Oct 17, 2024
trask
approved these changes
Oct 17, 2024
XSAM
reviewed
Oct 17, 2024
trask
reviewed
Oct 17, 2024
08c1d7d to
ed441ef
Compare
trask
reviewed
Oct 17, 2024
trask
reviewed
Oct 17, 2024
trask
reviewed
Oct 17, 2024
…to record single value
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
78cce84 to
457d6dc
Compare
joaopgrassi
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1159, #805
Related: #521
Based on the discussion on slack https://cloud-native.slack.com/archives/C06HH05KNMC/p1728891505239829 and spec discussion on 10/25/24:
We can however:
db.query.textas opt-in to mitigate shortcomings of single operation/collection name.SELECT foo, UPDATE bar, DELETE bar- it'd have low-ish cardinality, would be shorter than a query, won't have any sensitive information that needs sanitization and would be readable enough. This allows to make it recommended on metrics.This PR implements both options as discussed in #805 (comment)
Merge requirement checklist
[chore]schema-next.yaml updated with changes to existing conventions.