Feature Flag evaluation event#1440
Conversation
askpt
left a comment
There was a problem hiding this comment.
I added a couple of comments; otherwise, it looks good.
19453b5 to
97b68d8
Compare
|
FYI - you need to clean up the event group's id: |
|
@lmolkova I took the suggestion to use |
joaopgrassi
left a comment
There was a problem hiding this comment.
Please take a look and also, could you please update main/schema-next.yaml (list renamed attributes there)?
This is pending still.
Added There are a couple changes I'm not sure how to make there (or if it's possible).
|
According to https://opentelemetry.io/docs/specs/otel/schemas/file_format_v1.1.0 it looks like you can rename |
lmolkova
left a comment
There was a problem hiding this comment.
There are a couple changes I'm not sure how to make there (or if it's possible).
We removed the span semconv entirely in favor of events
We renamed the event from feature_flag to event.feature_flag.evaluation
changelog entry is the best we can do today. Added some suggestions
Co-authored-by: Liudmila Molkova <[email protected]>
|
@dyladan This Looks good to merge, assuming the conversations are resolved. The yamllint error - let me know if we need to update the settings. We may be hitting limitations in YAML event definitions and "max line length" rules... |
I wish the yaml lint would tell me which line is failing. I can't find where the error is actually caused. I think it's likely the table that I inlined for the error values? But that's only 197 characters |
First draft of
feature_flag.evaluationevent from the feature flag semantic conventions working group. Based on proposal here: https://docs.google.com/document/d/1sBDD-uifx-Qy0NxtwRcrRAQ48sHQS9dTp6tpArQsoZg/editSummary of changes:
feature_flag.provider_namewithfeature_flag.provider.idfeature_flag.systemfeature_flagtofeature_flag.evaluationfeature_flag.evaluationfeature_flag.context.idfeature_flag.environment.idfeature_flag.flag_set.idfeature_flag.valuefeature_flag.versionfeature_flag.error.codewith values from https://openfeature.dev/specification/types/#resolution-detailsfeature_flag.reasonwith values from https://openfeature.dev/specification/types/#resolution-details