Add k8s.{pod,node}.memory.usage metrics#1406
Merged
lmolkova merged 3 commits intoopen-telemetry:mainfrom Sep 21, 2024
Merged
Conversation
ChrsMark
force-pushed
the
add_k8s_memory_usage
branch
2 times, most recently
from
13d9775 to
7d426df
Compare
AlexanderWert
approved these changes
Sep 16, 2024
jsuereth
requested changes
Sep 17, 2024
Contributor
jsuereth
left a comment
jsuereth
left a comment
There was a problem hiding this comment.
New metrics LGTM but this PR needs to be updated with changes in structure.
Signed-off-by: ChrsMark <[email protected]>
ChrsMark
force-pushed
the
add_k8s_memory_usage
branch
from
7d426df to
1ea59c9
Compare
TylerHelmuth
approved these changes
Sep 17, 2024
jsuereth
approved these changes
Sep 19, 2024
Contributor
jsuereth
left a comment
jsuereth
left a comment
There was a problem hiding this comment.
This looks fine to me, but I'm finding metrics with no attributes problematic in documentation.
I think we should have recommendations/requirements on what resources metrics can/must associate with, e.g. I expect these metrics would need to be associated with a k8s.pod or k8s.node right?
This is for resolution outside this PR.
jsuereth
approved these changes
Sep 20, 2024
drewby
pushed a commit
to drewby/otel-semantic-conventions
that referenced
this pull request
Oct 1, 2024
Signed-off-by: ChrsMark <[email protected]> Co-authored-by: Liudmila Molkova <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1032
Changes
This PR adds the
k8s.pod.memory.usageandk8s.node.memory.usagemetrics which are already used in thekubeletstatsreceiver of the Collector:Merge requirement checklist
[chore]