CosmosDB: define applicable values for db.operation.name and add proper reference to az.namespace#1330
Merged
lmolkova merged 12 commits intoopen-telemetry:mainfrom Aug 23, 2024
Conversation
lmolkova
changed the title
db.operation.namedb.operation.name and add proper reference to az.namespace
jcocchi
reviewed
Aug 9, 2024
jcocchi
reviewed
Aug 9, 2024
jcocchi
reviewed
Aug 9, 2024
jcocchi
reviewed
Aug 9, 2024
jcocchi
reviewed
Aug 9, 2024
lmolkova
force-pushed
the
cosmos-define-operation-names
branch
from
7f257df to
5391024
Compare
lmolkova
commented
Aug 9, 2024
lmolkova
commented
Aug 9, 2024
FabianMeiswinkel
suggested changes
Aug 11, 2024
FabianMeiswinkel
left a comment
FabianMeiswinkel
left a comment
There was a problem hiding this comment.
I think transactional batch but especially bulk needs some more thoughts. Bulk operations are done fundamentally differently in Java and .Net. In Bulk there is an explicit API for executing a set of operations as bulk - so something like execute_bulk would probably be good? In .Net whether point operations are executed as bulk or normally depends on some config on the client - which right now you result in create or read covering operations that are actually executed as part of a bulk operation and would have completely different non-functional characteristics like perf.
lmolkova
commented
Aug 16, 2024
lmolkova
force-pushed
the
cosmos-define-operation-names
branch
from
aead156 to
4179c49
Compare
joaopgrassi
approved these changes
Aug 20, 2024
jcocchi
approved these changes
Aug 20, 2024
Contributor
jcocchi
left a comment
jcocchi
left a comment
There was a problem hiding this comment.
Looks good to me! Left one minor comment
lmolkova
force-pushed
the
cosmos-define-operation-names
branch
from
4179c49 to
d34d6cb
Compare
trask
approved these changes
Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
az.namespaceattribute and reference it (previously undefined, but referenced in md)Merge requirement checklist
[chore]