Add container.cpu.usage metric#1128
Merged
lmolkova merged 13 commits intoopen-telemetry:mainfrom Aug 5, 2024
Merged
Conversation
trisch-me
approved these changes
Jun 6, 2024
lmolkova
reviewed
Jun 11, 2024
lmolkova
reviewed
Jun 11, 2024
ChrsMark
force-pushed
the
add_container_cpu_usage
branch
from
8f91fc8 to
05df82b
Compare
heyams
reviewed
Jun 13, 2024
lmolkova
reviewed
Jun 14, 2024
3 tasks
ChrsMark
force-pushed
the
add_container_cpu_usage
branch
2 times, most recently
from
15e0e08 to
dab7f82
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
dmitryax
approved these changes
Jul 12, 2024
Member
Author
|
@open-telemetry/semconv-k8s-approvers @open-telemetry/semconv-container-approvers @open-telemetry/specs-semconv-approvers could you take a look? |
TylerHelmuth
approved these changes
Jul 18, 2024
mx-psi
reviewed
Jul 18, 2024
mx-psi
approved these changes
Jul 19, 2024
Member
Author
|
@open-telemetry/specs-semconv-approvers since there are quite a few approvals by the k8s/container approvers can we move this one forward? |
joaopgrassi
approved these changes
Jul 23, 2024
Member
Author
|
Thank's @joaopgrassi! My only concern is about #1128 (comment). Does this look normal? |
ChrsMark
force-pushed
the
add_container_cpu_usage
branch
from
1e096e9 to
d968090
Compare
joaopgrassi
reviewed
Jul 30, 2024
lmolkova
approved these changes
Aug 3, 2024
Member
lmolkova
left a comment
lmolkova
left a comment
There was a problem hiding this comment.
Please fix anchor name and this PR should be good to go.
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Co-authored-by: Helen <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
ChrsMark
force-pushed
the
add_container_cpu_usage
branch
from
70dd573 to
9c12ac1
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1032
Changes
This PR adds the
container.cpu.usagemetric.This metric is implemented by the
kubeletstatsreceiver.This value comes from the
stats/summaryendpoint of Kubelet and its calculated at https://github.com/kubernetes/kubernetes/blob/v1.30.0/pkg/kubelet/stats/cri_stats_provider.go#L791-L800.It's not implemented by the
dockerstatsreceiver but that would be doable with something similar to https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.102.0/receiver/dockerstatsreceiver/metric_helper.go#L30, using the formula from the Kubelet's stats mentioned above.ref: https://docs.docker.com/engine/api/v1.45/#tag/Container/operation/ContainerStats
Merge requirement checklist
[chore]/cc @open-telemetry/semconv-container-approvers @open-telemetry/semconv-k8s-approvers