Session start and end events#1091
Conversation
bidetofevil
left a comment
bidetofevil
left a comment
There was a problem hiding this comment.
LGTM. One non-blocking question, and a suggestion to mention how the previous session ID can be used to signify that the previous session has ended - but again, non-blocking
breedx-splk
force-pushed
the
session_start_and_end_events
branch
from
2837df6 to
1ce116d
Compare
Co-authored-by: Joao Grassi <[email protected]>
Co-authored-by: Joao Grassi <[email protected]>
Co-authored-by: Joao Grassi <[email protected]>
|
@breedx-splk I think it would be good to have folks from the event and client working groups to take a look and approve this? Are you in touch with them? We don't seem to have a GitHub team for them so not sure how to get attention. |
scheler
left a comment
scheler
left a comment
There was a problem hiding this comment.
Mostly looks good, left a couple comments. I envision having named sessions in the long term, but it can be added in the future using a session.name field.
Co-authored-by: Liudmila Molkova <[email protected]>
|
3 approvals, are we waiting for anything else on this? 🙏🏻 |
|
@breedx-splk please resolve open discussions (if they are resolved) and it should be ready to go |
8 participants
Changes
This serves as an alternative/successor to #1042. Instead of describing a session change event, we have a session start and session end event instead.
Merge requirement checklist
[chore]