Skip to content

Merge *.cpu.state attributes to a common cpu.mode attribute#1026

Merged
joaopgrassi merged 18 commits intoopen-telemetry:mainfrom
ChrsMark:merge_cpu_states
Jun 26, 2024
Merged

Merge *.cpu.state attributes to a common cpu.mode attribute#1026
joaopgrassi merged 18 commits intoopen-telemetry:mainfrom
ChrsMark:merge_cpu_states

Conversation

@ChrsMark
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark commented May 10, 2024 •
edited
Loading

Fixes #840

Changes

This PR introduces a common cpu.state cpu.mode attribute which is a converged attribute from the system.cpu.state, process.cpu.state and container.cpu.state.

Merge requirement checklist

@ChrsMark ChrsMark requested review from a team May 10, 2024 10:07
@ChrsMark ChrsMark self-assigned this May 10, 2024
trisch-me
trisch-me reviewed May 10, 2024
View reviewed changes
Comment thread docs/system/process-metrics.md
trisch-me
trisch-me reviewed May 10, 2024
View reviewed changes
Comment thread docs/system/container-metrics.md Outdated
@ChrsMark ChrsMark requested a review from a team May 10, 2024 10:21
@braydonk braydonk mentioned this pull request May 10, 2024
Closed
@ChrsMark ChrsMark force-pushed the merge_cpu_states branch 2 times, most recently from de27ecd to dbd49a4 Compare May 10, 2024 13:13
trisch-me
trisch-me reviewed May 10, 2024
View reviewed changes
Comment thread model/registry/system.yaml Outdated
trisch-me
trisch-me reviewed May 10, 2024
View reviewed changes
Comment thread model/registry/deprecated/container.yaml
lmolkova
lmolkova reviewed May 10, 2024
View reviewed changes
Comment thread model/registry/cpu.yaml Outdated
lmolkova
lmolkova approved these changes May 10, 2024
View reviewed changes
Comment thread model/registry/deprecated/process.yaml Outdated
Comment thread model/registry/deprecated/system.yaml Outdated
Comment thread model/registry/deprecated/container.yaml Outdated
Comment thread .chloggen/merge_cpu_states.yaml Outdated
@ChrsMark ChrsMark force-pushed the merge_cpu_states branch 2 times, most recently from 57eee6d to beb92b9 Compare May 13, 2024 08:45
joaopgrassi
joaopgrassi approved these changes May 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think you need to re-generate the make generate-gh-issue-templates though

@ChrsMark
Copy link
Copy Markdown
Member Author

ChrsMark commented May 15, 2024

Thank's @joaopgrassi. For some reason the make generate-gh-issue-templates does not change anything 🤔 .

@ChrsMark ChrsMark force-pushed the merge_cpu_states branch from 848fa37 to a7e9c02 Compare May 16, 2024 13:38
@ChrsMark
Copy link
Copy Markdown
Member Author

ChrsMark commented May 16, 2024

@open-telemetry/semconv-system-approvers could you take a look and specifically into the #1026 (comment)? Thank's.

trisch-me
trisch-me reviewed May 16, 2024
View reviewed changes
Comment thread docs/attributes-registry/cpu.md Outdated
trisch-me
trisch-me reviewed May 16, 2024
View reviewed changes
Comment thread model/registry/deprecated/container.yaml Outdated
trisch-me
trisch-me reviewed May 16, 2024
View reviewed changes
Comment thread model/registry/deprecated/process.yaml Outdated
trisch-me
trisch-me reviewed May 16, 2024
View reviewed changes
Comment thread model/registry/deprecated/system.yaml Outdated
@ChrsMark ChrsMark mentioned this pull request Jun 6, 2024
Open
@ChrsMark ChrsMark mentioned this pull request Jun 11, 2024
Closed
lmolkova
lmolkova reviewed Jun 11, 2024
View reviewed changes
Comment thread model/registry/cpu.yaml Outdated
@lmolkova lmolkova mentioned this pull request Jun 11, 2024
Merged
3 tasks
@ChrsMark ChrsMark mentioned this pull request Jun 12, 2024
Merged
3 tasks
trisch-me
trisch-me reviewed Jun 21, 2024
View reviewed changes
Comment thread model/registry/deprecated/container.yaml Outdated
trisch-me
trisch-me reviewed Jun 21, 2024
View reviewed changes
Comment thread model/registry/deprecated/container.yaml Outdated
trisch-me
trisch-me reviewed Jun 21, 2024
View reviewed changes
Comment thread model/registry/deprecated/process.yaml Outdated
trisch-me
trisch-me reviewed Jun 21, 2024
View reviewed changes
Comment thread model/registry/deprecated/process.yaml Outdated
trisch-me
trisch-me reviewed Jun 21, 2024
View reviewed changes
Comment thread model/registry/deprecated/system.yaml Outdated
trisch-me
trisch-me reviewed Jun 21, 2024
View reviewed changes
Comment thread schema-next.yaml Outdated
@trisch-me
Copy link
Copy Markdown
Contributor

trisch-me commented Jun 21, 2024

You need to regenerate registry to update md files to fix the issue

@ChrsMark
fix mds
4a2915a 
Signed-off-by: ChrsMark <[email protected]>
lmolkova
lmolkova approved these changes Jun 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just left a few minor comments.

Comment thread model/metrics/system-metrics.yaml Outdated
Comment thread model/metrics/system-metrics.yaml Outdated
Comment thread model/registry/cpu.yaml
Comment thread schema-next.yaml
braydonk
braydonk reviewed Jun 21, 2024
View reviewed changes
Comment thread model/metrics/system-metrics.yaml Outdated
ChrsMark and others added 5 commits June 25, 2024 09:54
@ChrsMark
Update model/metrics/system-metrics.yaml
a71a68c 
Co-authored-by: Liudmila Molkova <[email protected]>
@ChrsMark
Update schema-next.yaml
0d8bbb6 
Co-authored-by: Liudmila Molkova <[email protected]>
@ChrsMark @braydonk
Update model/metrics/system-metrics.yaml
acf4c78 
Co-authored-by: Braydon Kains <[email protected]>
@ChrsMark
Update model/metrics/system-metrics.yaml
b5249eb 
Co-authored-by: Liudmila Molkova <[email protected]>
@ChrsMark
update MDs
8d897b8 
Signed-off-by: ChrsMark <[email protected]>
@joaopgrassi joaopgrassi merged commit db1b84d into open-telemetry:main Jun 26, 2024
@bryannaegele bryannaegele mentioned this pull request Jul 25, 2024
Merged
@ChrsMark ChrsMark mentioned this pull request Jun 10, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trisch-me trisch-me trisch-me approved these changes

@lmolkova lmolkova lmolkova approved these changes

@mx-psi mx-psi mx-psi approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@braydonk braydonk braydonk approved these changes

Assignees

@joaopgrassi joaopgrassi

@ChrsMark ChrsMark

Labels

None yet

Projects

Semantic Conventions Triage
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider merging *.cpu.state metric attributes

7 participants

@ChrsMark @trisch-me @lmolkova @mx-psi @joaopgrassi @TylerHelmuth @braydonk