Skip to content

Clarify case normalization in db spec#1004

Merged
lmolkova merged 4 commits intoopen-telemetry:mainfrom
gregkalapos:db_case_normalization
May 7, 2024
Merged

Clarify case normalization in db spec#1004
lmolkova merged 4 commits intoopen-telemetry:mainfrom
gregkalapos:db_case_normalization

Conversation

@gregkalapos
Copy link
Copy Markdown
Member

@gregkalapos gregkalapos commented May 3, 2024 •
edited
Loading

Fixes #886

Changes

Adding note about case normalization to following attributes:

  • db.collection.name
  • db.namespace
  • db.operation.name

The added note suggested in #886

It is RECOMMENDED to capture the value as provided by the application without attempting to do any case normalization.

Merge requirement checklist

@gregkalapos gregkalapos requested review from a team May 3, 2024 15:20
@gregkalapos gregkalapos changed the title Clarify case normalization in db spec [chore] Clarify case normalization in db spec May 3, 2024
@trask
Copy link
Copy Markdown
Member

trask commented May 7, 2024

I think probably needs a change log

lmolkova
lmolkova reviewed May 7, 2024
View reviewed changes
Comment thread model/registry/db.yaml
@gregkalapos gregkalapos changed the title [chore] Clarify case normalization in db spec Clarify case normalization in db spec May 7, 2024
@gregkalapos gregkalapos force-pushed the db_case_normalization branch from ef698e3 to dd46bac Compare May 7, 2024 17:19
@gregkalapos
Copy link
Copy Markdown
Member Author

gregkalapos commented May 7, 2024

CI fails with:

34s
Run make markdown-link-check
  make markdown-link-check
  shell: /usr/bin/bash -e {0}
fatal: No names found, cannot describe anything.
semantic-conventions@ /home/runner/work/semantic-conventions/semantic-conventions
└── [email protected]


  ERROR: 1 dead links found in ./docs/attributes-registry/db.md !
  [✖] https://docs.datastax.com/en/cassandra-oss/3.0/cassandra/dml/dmlConfigConsistency.html → Status: 404
make: *** [Makefile:47: markdown-link-check] Error 1
Error: Process completed with exit code 2.

That link works from my browser - and the PR doesn't really change anything around it. Strange. Trying to figure this out.

@lmolkova lmolkova merged commit 5c3e4f1 into open-telemetry:main May 7, 2024
drewby pushed a commit to drewby/otel-semantic-conventions that referenced this pull request May 23, 2024
@gregkalapos @drewby
Clarify case normalization in db spec (open-telemetry#1004)
300aeff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmolkova lmolkova lmolkova approved these changes

@trask trask trask approved these changes

Assignees

@AlexanderWert AlexanderWert

Labels

None yet

Projects

Semantic Conventions Triage
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Case normalization in db.name, db.collection.name, db.operation.name?

4 participants

@gregkalapos @trask @lmolkova @AlexanderWert