RFC 0003, 0007 updates (Metrics measure type, metrics handle specification), RFC 0004 (configurable aggregation) deleted by jmacd · Pull Request #29 · open-telemetry/oteps

jmacd · 2019-08-27T08:31:52Z

Updates to 0003 following work session 8/21/2019

Some content has been moved to a new RFC on metric handles.

This captures most of the discussion from the 8/21 meeting and mostly eliminates the need for RFC 0004.

lzchen · 2019-08-27T22:24:19Z

In summary, these are the agreements that this RFC addresses:

Agreement on context association across the metrics surface.
Agreement: Two diff interfaces - 1) For defining local labels 2) Metric operations
getHandle(labels) -> return handle object
handle.set() or handle.add()
Agreement: Call site variables can be supported by context tags
Agreement: All defined labels are captured in handles
Unspecified values will be accepted but will not be treated as empty
Agreement: Context tags do not override handles tags
Do not list remote tags for pre-aggregation (when you declare the metric)
Agreement: No support delta metric type. All type should support increments and decrements (AI: come up with names for a-c)
Set can have the option to restrict values to increase
Add can have the option to restrict to +ive values
Record can have the option to be restricted to only +ive values
Agreement: Metric type will have default aggregation and will have the option of enabling them.
Agreement: Support Context-less Set (aka callbacks) for observing current value metrics (snapshots) (bullet 6,7 applies to 8)

Agreements that still need to be addressed:

Agreement: Supporting order based and non order based getHandle()
Order based handles can throw exceptions: as determined by language
Non-order based handles can fill-in unspecified-value automatically (point 4 in addressed)
Agreement: Provide transformer for external metrics provider like drop-wizzard (rather than callback observer). (details on this?)
Agreement: Resources are associated with SDK Manager, Component is associated with Tracer/Meter, metric name is unique per component (in prometheus exporter we would add component name as prefix).
Vector metrics? (prometheus)

@jmacd Feel free to edit if I'm missing anything!

lzchen · 2019-08-27T22:27:25Z

Looks good! I think we can address the other agreements maybe as edits to this RFC in the future once they are decided or simply push them up into the spec.

songy23 · 2019-09-04T22:05:55Z

https://circleci.com/gh/open-telemetry/oteps/115?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

./text/0003-measure-metric-type.md:5:2: "Foreward" is a misspelling of "Foreword"
./text/0003-measure-metric-type.md:113:294: "whic" is a misspelling of "which"

Please fix. (make misspell-correction should fix the typos.)

reyang · 2019-09-10T16:27:44Z

+
+## Motivation
+
+The specification currently names this concept `TimeSeries`, the object returned by `GetOrCreateTimeseries`, which supports binding a metric to a pre-defined set of labels for repeated use.  This proposal renames these `Handle` and `GetHandle`, respectively, and adds further detail to the API specification for handles.  


Having gauge.GetHandle(...) seems to be okay.
Having a class/type named Handle could be confusing.

In the Go prototype, there is indeed a Handle type but it's for internal use. The types returned by the GetHandle() methods in Go PR#100 are like Float64GaugeHandle, Int64CumulativeHandle. Is this sufficiently clear?

jmacd · 2019-09-11T05:09:09Z

I will revise this RFC again tomorrow with some of the outcome of today's metrics meeting. For now, I've allocated number 0007-metric-handle, making it precede 0008-metric-observer in PR#39.

jmacd · 2019-09-11T18:22:37Z

Update: It's been suggested that this PR is too long to be useful, and I would like to propose merging it in the current "proposed" state. I will immediately open another PR for further comments as I begin another round of updates regarding the LabelSet discussion yesterday.

@bogdandrutu

* span operations API * fixed TBD on span * fixed a link * addressed Bogdan's feedback * fixed optionality of attributes * Update tracing-api.md

…ation), RFC 0004 (configurable aggregation) deleted (open-telemetry#29) * Updates to 0003 following work session 8/21/2019 * Update date * Feedback applied * Feedback applied * Remove handle specification, will create another RFC * More typing * Add metrics handles RFC * Rename 0000 * Remove 0004 * Add an open question from python PR87 * Add an open question about RecordBatch * Clarify the open questions * Name NonNegative and NonDescending options * Clarify the Measurement unit for RecordBatch * Add issues addressed * Linkify * Linkify * Format * Address option names and default settings * Answer questions * Spelling * Use 0007 * Refer to 0008 * Take suggestion

…ation), RFC 0004 (configurable aggregation) deleted (open-telemetry/oteps#29) * Updates to 0003 following work session 8/21/2019 * Update date * Feedback applied * Feedback applied * Remove handle specification, will create another RFC * More typing * Add metrics handles RFC * Rename 0000 * Remove 0004 * Add an open question from python PR87 * Add an open question about RecordBatch * Clarify the open questions * Name NonNegative and NonDescending options * Clarify the Measurement unit for RecordBatch * Add issues addressed * Linkify * Linkify * Format * Address option names and default settings * Answer questions * Spelling * Use 0007 * Refer to 0008 * Take suggestion

Updates to 0003 following work session 8/21/2019

e401916

jmacd requested review from AloisReitbauer, SergeyKanzhelev, bogdandrutu, c24t, carlosalberto, iredelmeier, reyang, songy23, tedsuo and yurishkuro as code owners August 27, 2019 08:31

Update date

c4a7836

bogdandrutu reviewed Aug 27, 2019

View reviewed changes

Comment thread text/0003-measure-metric-type.md Outdated

Comment thread text/0003-measure-metric-type.md Outdated

bogdandrutu reviewed Aug 27, 2019

View reviewed changes

Comment thread text/0003-measure-metric-type.md

lizthegrey reviewed Aug 27, 2019

View reviewed changes

Comment thread text/0003-measure-metric-type.md Outdated

lzchen reviewed Aug 27, 2019

View reviewed changes

Comment thread text/0003-measure-metric-type.md Outdated

Josh MacDonald added 2 commits August 27, 2019 15:02

Feedback applied

beff7cf

Feedback applied

0aa9665

lzchen reviewed Aug 27, 2019

View reviewed changes

Comment thread text/0003-measure-metric-type.md

jmacd mentioned this pull request Aug 30, 2019

Golang metrics prototype open-telemetry/opentelemetry-go#100

Merged

krnowak reviewed Aug 30, 2019

View reviewed changes

Comment thread text/0003-measure-metric-type.md Outdated

Upstream

2c749d8

tedsuo reviewed Sep 1, 2019

View reviewed changes

Comment thread text/0003-measure-metric-type.md Outdated

jmacd added 2 commits September 1, 2019 20:52

Remove handle specification, will create another RFC

7d5bee5

More typing

2e541db

tedsuo self-requested a review September 3, 2019 03:39

tedsuo approved these changes Sep 3, 2019

View reviewed changes

Add metrics handles RFC

8e9fcc3

jmacd added 3 commits September 4, 2019 14:49

Linkify

fd1c027

Linkify

deb6fac

Format

a1e526d

jmacd added 3 commits September 4, 2019 16:11

Address option names and default settings

9aee892

Answer questions

7ae4bd8

Spelling

18587f6

lizthegrey approved these changes Sep 10, 2019

View reviewed changes

reyang reviewed Sep 10, 2019

View reviewed changes

Comment thread text/0000-metric-handles.md Outdated

reyang reviewed Sep 10, 2019

View reviewed changes

jmacd added 2 commits September 10, 2019 22:04

Use 0007

c3225a2

Refer to 0008

f1e5972

Take suggestion

ec53885

jmacd changed the title ~~Metrics measure type [update] and metrics handle specification~~ WIP: RFC 0003, 0007 updates (Metrics measure type, metrics handle specification), RFC 0004 (configurable aggregation) deleted Sep 11, 2019

jmacd mentioned this pull request Sep 11, 2019

Acceptance PRs for proposed OTEPs #44

Closed

lzchen approved these changes Sep 11, 2019

View reviewed changes

bogdandrutu approved these changes Sep 11, 2019

View reviewed changes

carlosalberto approved these changes Sep 11, 2019

View reviewed changes

songy23 approved these changes Sep 11, 2019

View reviewed changes

songy23 changed the title ~~WIP: RFC 0003, 0007 updates (Metrics measure type, metrics handle specification), RFC 0004 (configurable aggregation) deleted~~ RFC 0003, 0007 updates (Metrics measure type, metrics handle specification), RFC 0004 (configurable aggregation) deleted Sep 11, 2019

yurishkuro merged commit 3e9d81d into open-telemetry:master Sep 12, 2019

mayurkale22 mentioned this pull request Sep 12, 2019

feat: Metrics API revision based on Specs and RFCs open-telemetry/opentelemetry-js#259

Merged

jmacd deleted the jmacd/update_0003 branch September 13, 2019 18:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RFC 0003, 0007 updates (Metrics measure type, metrics handle specification), RFC 0004 (configurable aggregation) deleted#29

RFC 0003, 0007 updates (Metrics measure type, metrics handle specification), RFC 0004 (configurable aggregation) deleted#29
yurishkuro merged 26 commits intoopen-telemetry:masterfrom
jmacd:jmacd/update_0003

jmacd commented Aug 27, 2019 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lzchen commented Aug 27, 2019 •

edited

Loading

Uh oh!

lzchen commented Aug 27, 2019

Uh oh!

Uh oh!

Uh oh!

songy23 commented Sep 4, 2019 •

edited

Loading

Uh oh!

Uh oh!

reyang Sep 10, 2019

Uh oh!

jmacd Sep 11, 2019

Uh oh!

jmacd commented Sep 11, 2019

Uh oh!

jmacd commented Sep 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants


		## Motivation

		The specification currently names this concept `TimeSeries`, the object returned by `GetOrCreateTimeseries`, which supports binding a metric to a pre-defined set of labels for repeated use. This proposal renames these `Handle` and `GetHandle`, respectively, and adds further detail to the API specification for handles.

Conversation

jmacd commented Aug 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lzchen commented Aug 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lzchen commented Aug 27, 2019

Uh oh!

Uh oh!

Uh oh!

songy23 commented Sep 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

reyang Sep 10, 2019

Choose a reason for hiding this comment

Uh oh!

jmacd Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

jmacd commented Sep 11, 2019

Uh oh!

jmacd commented Sep 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

jmacd commented Aug 27, 2019 •

edited

Loading

lzchen commented Aug 27, 2019 •

edited

Loading

songy23 commented Sep 4, 2019 •

edited

Loading