Skip to content
This repository was archived by the owner on Nov 17, 2025. It is now read-only.

Event basics#265

Merged
jsuereth merged 27 commits intoopen-telemetry:mainfrom
trask:event-basics
Sep 19, 2024
Merged

Event basics#265
jsuereth merged 27 commits intoopen-telemetry:mainfrom
trask:event-basics

Conversation

@trask
Copy link
Copy Markdown
Member

@trask trask commented Aug 27, 2024

No description provided.

jack-berg
jack-berg reviewed Aug 27, 2024
View reviewed changes
Comment thread text/9999-event-vision.md Outdated
lmolkova
lmolkova reviewed Aug 27, 2024
View reviewed changes
Comment thread text/9999-event-vision.md Outdated
Comment thread text/9999-event-vision.md Outdated
jack-berg
jack-berg approved these changes Aug 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is just a draft, but I support the ideas here. Let's have the debate about the high level direction of events and logs once, here. Assuming we agree and merge, we can focus on the details of making the vision a reality, without having to re-litigate the overall direction with each discussion.

@trask trask marked this pull request as ready for review August 28, 2024 14:57
@jack-berg jack-berg mentioned this pull request Aug 28, 2024
Closed
cijothomas
cijothomas reviewed Aug 28, 2024
View reviewed changes
Comment thread text/0265-event-vision.md Outdated
cijothomas
cijothomas reviewed Aug 28, 2024
View reviewed changes
Comment thread text/0265-event-vision.md Outdated
cijothomas
cijothomas reviewed Aug 28, 2024
View reviewed changes
Comment thread text/0265-event-vision.md Outdated
cijothomas
cijothomas reviewed Aug 28, 2024
View reviewed changes
Comment thread text/0265-event-vision.md Outdated
jkwatson
jkwatson reviewed Aug 28, 2024
View reviewed changes
Comment thread text/0265-event-vision.md Outdated
jkwatson
jkwatson reviewed Aug 28, 2024
View reviewed changes
Comment thread text/0265-event-vision.md Outdated
cijothomas
cijothomas reviewed Aug 28, 2024
View reviewed changes
Comment thread text/0265-event-vision.md Outdated
cijothomas
cijothomas reviewed Aug 28, 2024
View reviewed changes
Comment thread text/0265-event-vision.md Outdated
MSNev
MSNev reviewed Aug 28, 2024
View reviewed changes
Comment thread text/0265-event-vision.md Outdated
MSNev
MSNev reviewed Aug 28, 2024
View reviewed changes
Comment thread text/0265-event-vision.md Outdated
danelson
danelson reviewed Aug 28, 2024
View reviewed changes
Comment thread text/0265-event-vision.md Outdated
@trask
Copy link
Copy Markdown
Member Author

trask commented Aug 29, 2024 •
edited
Loading

(just a heads up to reviewers, due to volume of comments, I'm resolving those that I think are addressed so we can focus on the remaining questions, but please feel free to unresolve any if you think they need more discussion)

EDIT: since some of the discussions are quite long, instead of unresolving it may help instead to start a new discussion with a summary of remaining discussion points (along with a pointer to the prior discussion for full context)

joaopgrassi
joaopgrassi reviewed Aug 30, 2024
View reviewed changes
Comment thread text/0265-event-vision.md Outdated
Comment thread text/0265-event-vision.md Outdated
Comment thread text/0265-event-vision.md Outdated
Comment thread text/0265-event-vision.md Outdated
Comment thread text/0265-event-vision.md Outdated
Comment thread text/0265-event-vision.md Outdated
Comment thread text/0265-event-vision.md Outdated
trask
trask commented Aug 30, 2024
View reviewed changes
Comment thread text/0265-event-vision.md Outdated
@lmolkova
Copy link
Copy Markdown
Member

lmolkova commented Aug 30, 2024 •
edited
Loading

WRT why do we need new APIs (leaving naming aside), I created this comparison of key features

Feature Event/Logging v2 API 'Traditional' Logging API
Formatted string body ❔ not a priority ✅ common case
Complex body ✅ common case ❌ usually not supported or stringified
Extra properties ✅ attributes ✅ attributes (or not supported)
Named and identifiable ✅ always ❔ (depends on app, inconsistent)
Predictable structure ✅ highly encouraged ❔ (depends on app, inconsistent)
Semantics and stability guarantees ➕ depends on app, encouraged ❔ (depends on app, usually no expectations)
How to consume 💻 query, aggregate, auto-analyze ❔ read + grep by humans, parse and re-create structure to be used by tools. Depends on app
Filtering by scope + name + severity (API support) future ✅ yes, usually by scope + severity
Severity ❔ optional ✅ required
Context ✅ explicit ❔ implicit or none

[update] big thanks to @cijothomas for pointing out difference around severity

@cijothomas cijothomas mentioned this pull request Sep 16, 2024
Open
MrAlias
MrAlias reviewed Sep 16, 2024
View reviewed changes
Comment thread text/0265-event-vision.md Outdated
@jsuereth
Copy link
Copy Markdown
Contributor

jsuereth commented Sep 18, 2024

This OTEP now passes requirements to merge, outside of waiting 2 business days after the last change. This will be merged tomorrow.

@cijothomas cijothomas mentioned this pull request Sep 19, 2024
Closed
@jsuereth jsuereth merged commit 87e944b into open-telemetry:main Sep 19, 2024
@trask trask deleted the event-basics branch September 19, 2024 21:34
@pellared pellared mentioned this pull request Sep 25, 2024
Closed
@atreat atreat mentioned this pull request Sep 26, 2024
Open
@trask trask mentioned this pull request Sep 30, 2024
Closed
@MSNev MSNev mentioned this pull request Oct 1, 2024
Merged
@lmolkova lmolkova mentioned this pull request Oct 8, 2024
Closed
lmolkova pushed a commit to open-telemetry/opentelemetry-specification that referenced this pull request Oct 9, 2024
@MSNev @pellared @trask
Introduce the new user-facing Logs API as a placeholder (#4236)
b9d347a 
Part of open-telemetry/oteps#265

---------

Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 23, 2024
@trask
Event basics (open-telemetry#265)
5e6379b
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 23, 2024
@trask
Event basics (open-telemetry#265)
4b16697
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 30, 2024
@trask
Event basics (open-telemetry#265)
7b24193
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@trask
Event basics (open-telemetry/oteps#265)
ffef8c6
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@MSNev @pellared @trask
Introduce the new user-facing Logs API as a placeholder (open-telemet…
559ecc6 
…ry#4236)

Part of open-telemetry/oteps#265

---------

Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 31, 2024
@trask
Event basics (open-telemetry#265)
a8fc028
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Nov 1, 2024
@trask
Event basics (open-telemetry#265)
a65d54c
carlosalberto pushed a commit to open-telemetry/opentelemetry-specification that referenced this pull request Nov 8, 2024
@trask @carlosalberto
Event basics (open-telemetry/oteps#265)
9aa5400
@trask trask mentioned this pull request Dec 6, 2024
Merged
@trask trask mentioned this pull request Feb 6, 2025
Closed
This was referenced Feb 6, 2025
Closed
Closed
@trask trask mentioned this pull request Feb 28, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

25 more reviewers

@tedsuo tedsuo tedsuo approved these changes

@heyams heyams heyams left review comments

@danelson danelson danelson left review comments

@joaopgrassi joaopgrassi joaopgrassi left review comments

@jkwatson jkwatson jkwatson left review comments

@MrAlias MrAlias MrAlias approved these changes

@cijothomas cijothomas cijothomas approved these changes

@pellared pellared pellared approved these changes

@jaydeluca jaydeluca jaydeluca approved these changes

@scheler scheler scheler approved these changes

@jmacd jmacd jmacd approved these changes

@austinlparker austinlparker austinlparker approved these changes

@dyladan dyladan dyladan approved these changes

@svrnm svrnm svrnm approved these changes

@mtwo mtwo mtwo approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@lmolkova lmolkova lmolkova approved these changes

@XSAM XSAM XSAM approved these changes

@lzchen lzchen lzchen approved these changes

@reyang reyang reyang approved these changes

@jack-berg jack-berg jack-berg approved these changes

@mattmccleary mattmccleary mattmccleary approved these changes

@MSNev MSNev MSNev approved these changes

@trentm trentm trentm approved these changes

@jsuereth jsuereth jsuereth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.