Skip to content

Add Logs section in Python Instrumentation#7106

Merged
tiffany76 merged 9 commits intoopen-telemetry:mainfrom
hectorhdzg:hectorhdzg/pythonlogs
Jun 17, 2025
Merged

Add Logs section in Python Instrumentation#7106
tiffany76 merged 9 commits intoopen-telemetry:mainfrom
hectorhdzg:hectorhdzg/pythonlogs

Conversation

@hectorhdzg
Copy link
Copy Markdown
Member

@hectorhdzg hectorhdzg commented Jun 13, 2025

Adding Logs section in Python Instrumentation, this is being tracked in Python Logging API/SDK RC, it should be merged when Logs API/SDK is ready in Python.

Fixes: open-telemetry/opentelemetry-python#3551

@hectorhdzg hectorhdzg requested a review from a team as a code owner June 13, 2025 21:58
@opentelemetrybot opentelemetrybot requested a review from a team June 13, 2025 21:58
@tiffany76
Copy link
Copy Markdown
Member

tiffany76 commented Jun 16, 2025

/fix:format

@opentelemetrybot
Copy link
Copy Markdown
Contributor

opentelemetrybot commented Jun 16, 2025

✅ fix:format applied successfully in this run.

@cartermp
Copy link
Copy Markdown
Contributor

cartermp commented Jun 16, 2025

@hectorhdzg why wait until it is ready? Do the install or setup instructions differ unless you have the RC package?

Asking since I'd much rather let people use logs now, even if it's potentially changing a bit, than give the impression that OTel Python doesn't have any logs support yet (which is feedback I have received recently).

@tiffany76
Copy link
Copy Markdown
Member

tiffany76 commented Jun 16, 2025

/fix:refcache

@opentelemetrybot
Copy link
Copy Markdown
Contributor

opentelemetrybot commented Jun 16, 2025

✅ fix:refcache applied successfully in this run.

@tiffany76
Copy link
Copy Markdown
Member

tiffany76 commented Jun 16, 2025

@open-telemetry/python-approvers, would anyone else like to review this and weigh in on whether to publish now or keep it on hold?

emdneto
emdneto reviewed Jun 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@emdneto emdneto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t see any issue with publishing this, since it includes a warning saying that the Logs API/SDK is still under development. Right now, as a user I have to browse the otel-python repository to find some examples of how to instrument logs

Comment thread content/en/docs/languages/python/instrumentation.md Outdated
@tammy-baylis-swi
Copy link
Copy Markdown
Contributor

tammy-baylis-swi commented Jun 17, 2025

I agree with @emdneto ; it will help to have something in that section of the page now.

@opentelemetrybot opentelemetrybot requested a review from a team June 17, 2025 16:59
@hectorhdzg
Copy link
Copy Markdown
Member Author

hectorhdzg commented Jun 17, 2025

I actually removed the warning of logs being under development in first iteration, added back now

tammy-baylis-swi
tammy-baylis-swi reviewed Jun 17, 2025
View reviewed changes
Comment thread content/en/docs/languages/python/instrumentation.md Outdated
@cartermp
Copy link
Copy Markdown
Contributor

cartermp commented Jun 17, 2025

/fix:format

@opentelemetrybot
Copy link
Copy Markdown
Contributor

opentelemetrybot commented Jun 17, 2025

✅ fix:format applied successfully in this run.

tammy-baylis-swi
tammy-baylis-swi approved these changes Jun 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cartermp !

This lgtm

@cartermp cartermp enabled auto-merge June 17, 2025 18:36
@tiffany76 tiffany76 disabled auto-merge June 17, 2025 22:42
@opentelemetrybot opentelemetrybot requested a review from a team June 17, 2025 23:37
@tiffany76 tiffany76 added this pull request to the merge queue Jun 17, 2025
Merged via the queue into open-telemetry:main with commit 3d737b7 Jun 17, 2025
19 checks passed
tiffany76 added a commit to BeverlyJaneJ/opentelemetry.io that referenced this pull request Jun 18, 2025
@hectorhdzg @opentelemetrybot @tiffany76
Add Logs section in Python Instrumentation (open-telemetry#7106)
70678a9 
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cartermp cartermp cartermp approved these changes

@emdneto emdneto emdneto approved these changes

@tiffany76 tiffany76 tiffany76 approved these changes

+1 more reviewer

@tammy-baylis-swi tammy-baylis-swi tammy-baylis-swi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

sig:python

Projects

SIG Comms: PRs & Issues
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Planning to add docs on logs in Getting Started?

6 participants

@hectorhdzg @tiffany76 @opentelemetrybot @cartermp @tammy-baylis-swi @emdneto