Skip to content

Describe association between Sampler and TracerProvider.#932

Merged
carlosalberto merged 6 commits intoopen-telemetry:masterfrom
dynatrace-oss-contrib:tracerprovider-sampler
Sep 11, 2020
Merged

Describe association between Sampler and TracerProvider.#932
carlosalberto merged 6 commits intoopen-telemetry:masterfrom
dynatrace-oss-contrib:tracerprovider-sampler

Conversation

@Oberon00
Copy link
Copy Markdown
Member

@Oberon00 Oberon00 commented Sep 9, 2020

Fixes #781.

Note that how span and trace IDs are (not) to be generated is currently unspecified, see #864

Changes

  • Describes association of Sampler with TracerProvider. This is hopefully how everyone already implemented this.

@Oberon00 Oberon00 requested review from a team September 9, 2020 11:53
@Oberon00 Oberon00 added area:sampling Related to trace sampling area:sdk Related to the SDK priority:p3 Lowest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Sep 9, 2020
Comment thread specification/trace/sdk.md Outdated
@carlosalberto
Copy link
Copy Markdown
Contributor

cc @bogdandrutu (as in Java we store this in a TraceConfig object that belongs to TracerProvider ;) )

@bogdandrutu
Copy link
Copy Markdown
Member

Yes, but in Java the config is per TP so matches this.

@carlosalberto
Copy link
Copy Markdown
Contributor

This looks ready to merge. Please update @Oberon00

@carlosalberto carlosalberto merged commit 2ba84fe into open-telemetry:master Sep 11, 2020
@Oberon00 Oberon00 deleted the tracerprovider-sampler branch December 18, 2020 10:59
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
schmikei pushed a commit to schmikei/opentelemetry-specification that referenced this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:sampling Related to trace sampling area:sdk Related to the SDK priority:p3 Lowest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spec needs to mention that a Sampler is associated with a TracerProvider

4 participants