DocFX sanity check#742
Merged
carlosalberto merged 2 commits intoopen-telemetry:masterfrom Jul 27, 2020
Merged
Conversation
bogdandrutu
approved these changes
Jul 25, 2020
cijothomas
approved these changes
Jul 26, 2020
Oberon00
approved these changes
Jul 26, 2020
iNikem
reviewed
Jul 27, 2020
iNikem
reviewed
Jul 27, 2020
| - name: check out code | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: install docfx |
Contributor
There was a problem hiding this comment.
Why do you install it, if it is already checked into source control?
Member
Author
There was a problem hiding this comment.
The tool is not checked into source control.
Contributor
There was a problem hiding this comment.
What is docfx.cmd file below then?
Member
There was a problem hiding this comment.
A wrapper script to run docfx with the right options & exit code? https://github.com/open-telemetry/opentelemetry-specification/pull/742/files#diff-2fa7a6d21c1369efbff0a5d848afef7a
Member
Author
There was a problem hiding this comment.
Yes @Oberon00 is correct, it is a wrapper script to run docfx.exe.
arminru
approved these changes
Jul 27, 2020
carlosalberto
approved these changes
Jul 27, 2020
iNikem
approved these changes
Jul 27, 2020
This was referenced Sep 17, 2020
2 tasks
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
schmikei
pushed a commit
to schmikei/opentelemetry-specification
that referenced
this pull request
Apr 17, 2025
schmikei
pushed a commit
to schmikei/opentelemetry-specification
that referenced
this pull request
Apr 17, 2025
schmikei
pushed a commit
to schmikei/opentelemetry-specification
that referenced
this pull request
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added DocFx sanity check to the CI.
Fixed all the broken links.
Once this PR gets merged, no one is going to introduce broken link again.