Clarify semantic conventions around span start and end time#592
Merged
bogdandrutu merged 6 commits intoopen-telemetry:masterfrom Jun 30, 2020
Merged
Conversation
toumorokoshi
requested review from
SergeyKanzhelev,
arminru,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
yurishkuro
reviewed
May 10, 2020
yurishkuro
reviewed
May 10, 2020
Member
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
Why would we want to call this out just for HTTP spans? It is a general principle - if span represents an operation (be it an RPC or an internal function), its timestamps should be as close to operation start and end as possible.
Member
Author
I think that's fair. for http in particular web servers (and sometimes clients) incorporate some common middleware that adds to the cost of the request. I felt like the most ambiguity was there. I could take a stab at clarifying this is a more general place. |
Feedback states that the clarification around the meaning of the span start and end times could be more generic. Starting a proposal around by adding an example to the API.
toumorokoshi
changed the title
arminru
reviewed
May 11, 2020
Contributor
|
One thing to consider is to make the Http example a more general RPC one. No strong feeling though. Overall good as an example ;) |
Rewording recommendation to use a more generic RPC Adding a small blurb clarifying sub operations can be instrumented.
toumorokoshi
force-pushed
the
feature/span-duration-conventions
branch
from
1797a7d to
8099078
Compare
Member
Author
done! rewritten to a more generic RPC. |
arminru
approved these changes
May 18, 2020
Oberon00
reviewed
May 18, 2020
Oberon00
approved these changes
May 18, 2020
Member
|
Please resolve comments so we can get this merged :) |
Co-authored-by: Armin Ruech <[email protected]> Co-authored-by: Christian Neumüller <[email protected]>
Member
Author
|
@bogdandrutu addressed! |
arminru
approved these changes
May 19, 2020
Member
Author
|
@bogdandrutu these are addressed now, thanks! |
carlosalberto
added
spec:trace
bogdandrutu
approved these changes
Jun 30, 2020
codeboten
pushed a commit
to codeboten/opentelemetry-specification
that referenced
this pull request
Jul 20, 2020
…emetry#592) * Adding http semantic conventions for span start and end times. * Corrected send to end, further clarified timings. * Moving span operation clarification to api Feedback states that the clarification around the meaning of the span start and end times could be more generic. Starting a proposal around by adding an example to the API. * Addressing feedback Rewording recommendation to use a more generic RPC Adding a small blurb clarifying sub operations can be instrumented. * Apply suggestions from code review Co-authored-by: Armin Ruech <[email protected]> Co-authored-by: Christian Neumüller <[email protected]> * Expanding on child spans Co-authored-by: Armin Ruech <[email protected]> Co-authored-by: Christian Neumüller <[email protected]>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…emetry#592) * Adding http semantic conventions for span start and end times. * Corrected send to end, further clarified timings. * Moving span operation clarification to api Feedback states that the clarification around the meaning of the span start and end times could be more generic. Starting a proposal around by adding an example to the API. * Addressing feedback Rewording recommendation to use a more generic RPC Adding a small blurb clarifying sub operations can be instrumented. * Apply suggestions from code review Co-authored-by: Armin Ruech <[email protected]> Co-authored-by: Christian Neumüller <[email protected]> * Expanding on child spans Co-authored-by: Armin Ruech <[email protected]> Co-authored-by: Christian Neumüller <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #591.
Adding semantic conventions for http start and end times. This has previously caused some ambiguity in the start / end times that instrumentations should target.