Introduce the new user-facing Logs API as a placeholder#4236
Merged
lmolkova merged 34 commits intoopen-telemetry:mainfrom Oct 9, 2024
Merged
Introduce the new user-facing Logs API as a placeholder#4236lmolkova merged 34 commits intoopen-telemetry:mainfrom
lmolkova merged 34 commits intoopen-telemetry:mainfrom
Conversation
MSNev
force-pushed
the
MSNev/PublicLogsApi
branch
from
62841ce to
04cf254
Compare
MSNev
force-pushed
the
MSNev/PublicLogsApi
branch
from
04cf254 to
cc85d9c
Compare
lmolkova
reviewed
Oct 1, 2024
tedsuo
reviewed
Oct 1, 2024
trask
reviewed
Oct 1, 2024
MSNev
force-pushed
the
MSNev/PublicLogsApi
branch
3 times, most recently
from
1929a39 to
9d9c8f2
Compare
MSNev
force-pushed
the
MSNev/PublicLogsApi
branch
from
9d9c8f2 to
7c78eff
Compare
pellared
reviewed
Oct 1, 2024
pellared
reviewed
Oct 1, 2024
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
pellared
approved these changes
Oct 1, 2024
Co-authored-by: Robert Pająk <[email protected]>
trask
approved these changes
Oct 1, 2024
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
tedsuo
approved these changes
Oct 7, 2024
Contributor
tedsuo
left a comment
tedsuo
left a comment
There was a problem hiding this comment.
Looks great, let's get this merged and add the API method.
Contributor
Author
|
@trask, @lmolkova, @pellared can you please check the latest commit, it (should) include
Process taken: Merged changes from remote branch (which included the commits), updated missed renamings and pushed them back out (leading to loads of listed "commits" -- which should just be duplicative), I normally "cleanup" and squash the commits locally to keep it clean, but that requires a forced push to my branch and I didn't want to do that for this PR, hence the "messy" looking commits. |
trask
approved these changes
Oct 7, 2024
Member
trask
left a comment
trask
left a comment
There was a problem hiding this comment.
I think we may want to just call it the "Logs API" (which is enough to differentiate it from the "Logs Bridge API"), but I can propose that in a follow-up.
reyang
reviewed
Oct 7, 2024
pellared
approved these changes
Oct 7, 2024
jsuereth
approved these changes
Oct 8, 2024
mattmccleary
approved these changes
Oct 8, 2024
carlosalberto
approved these changes
Oct 8, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…ry#4236) Part of open-telemetry/oteps#265 --------- Co-authored-by: Robert Pająk <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]> Co-authored-by: Liudmila Molkova <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of open-telemetry/oteps#265