Remove docfx#4036
Merged
carlosalberto merged 4 commits intoopen-telemetry:mainfrom May 7, 2024
Merged
Conversation
trask
approved these changes
May 7, 2024
carlosalberto
approved these changes
May 7, 2024
Contributor
|
Let's give a heads up to people on today's Spec call, and otherwise let's merge this fast. |
MrAlias
approved these changes
May 7, 2024
tigrannajaryan
approved these changes
May 7, 2024
arminru
approved these changes
May 7, 2024
cijothomas
approved these changes
May 7, 2024
reyang
approved these changes
May 7, 2024
pellared
approved these changes
May 7, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
DocFx v3 is no longer available and not intended to be used externally. The feature it provided that we don't have from other tooling is cross-file anchor reference check, see open-telemetry/semantic-conventions#1009 for the details. It seems there is no popular (or even not popular) replacement for it. DocFx v2 only check anchors within the same file which markdownlint does as well. Related: open-telemetry/semantic-conventions#1008 Closes open-telemetry#4026.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DocFx v3 is no longer available and not intended to be used externally.
The feature it provided that we don't have from other tooling is cross-file anchor reference check, see open-telemetry/semantic-conventions#1009 for the details. It seems there is no popular (or even not popular) replacement for it.
DocFx v2 only check anchors within the same file which markdownlint does as well.
Related: open-telemetry/semantic-conventions#1008
Closes #4026.
Changes
This PR removes docfx since v2 does not provide additional value. We'll need to find a different solution for relative anchor checks.
CHANGELOG.mdfile updated for non-trivial changesspec-compliance-matrix.mdupdated if necessary