Skip to content

Fix docfx CI#4026

Closed
reyang wants to merge 5 commits intoopen-telemetry:mainfrom
reyang:reyang/docfx
Closed

Fix docfx CI#4026
reyang wants to merge 5 commits intoopen-telemetry:mainfrom
reyang:reyang/docfx

Conversation

@reyang
Copy link
Copy Markdown
Member

@reyang reyang commented Apr 30, 2024

@reyang reyang requested review from a team April 30, 2024 18:26
@MrAlias
Copy link
Copy Markdown
Contributor

MrAlias commented Apr 30, 2024

@reyang
Copy link
Copy Markdown
Member Author

reyang commented Apr 30, 2024

It seems like the action is still failing: https://github.com/open-telemetry/opentelemetry-specification/actions/runs/8899804175/job/24439957035?pr=4026

Is that the workflow this is intended to address?

That seems to be a different issue.

@breedx-splk
Copy link
Copy Markdown
Contributor

Thanks for tackling this @reyang would be great to get this going again. ☮️

@reyang
Copy link
Copy Markdown
Member Author

reyang commented Apr 30, 2024

The latest error seems to be coming from the tool itself which I haven't got time to follow up. https://github.com/open-telemetry/opentelemetry-specification/actions/runs/8900019522/job/24440633172?pr=4026

I think we can make it optional for now to unblock the PRs.

@reyang
Copy link
Copy Markdown
Member Author

reyang commented Apr 30, 2024

FYI @open-telemetry/technical-committee @open-telemetry/specs-approvers I've removed "Checks / docfx (pull_request)" from the Required CI for now.

@arminru arminru mentioned this pull request May 7, 2024
5 tasks
carlosalberto pushed a commit that referenced this pull request May 7, 2024
DocFx v3 is no longer available and not intended to be used externally.

The feature it provided that we don't have from other tooling is
cross-file anchor reference check, see
open-telemetry/semantic-conventions#1009 for
the details. It seems there is no popular (or even not popular)
replacement for it.

DocFx v2 only check anchors within the same file which markdownlint does
as well.

Related:
open-telemetry/semantic-conventions#1008

Closes #4026.
@reyang reyang deleted the reyang/docfx branch May 10, 2024 21:39
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
DocFx v3 is no longer available and not intended to be used externally.

The feature it provided that we don't have from other tooling is
cross-file anchor reference check, see
open-telemetry/semantic-conventions#1009 for
the details. It seems there is no popular (or even not popular)
replacement for it.

DocFx v2 only check anchors within the same file which markdownlint does
as well.

Related:
open-telemetry/semantic-conventions#1008

Closes open-telemetry#4026.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants