Allow Prometheus exporter to add resource attributes to metric attributes#3761
Merged
carlosalberto merged 19 commits intoopen-telemetry:mainfrom Nov 27, 2023
Merged
Conversation
…ributes to each exported metric attributes
Contributor
Author
|
@dashpole I wasn't sure what to do with changelog and matrix |
dashpole
approved these changes
Nov 13, 2023
MrAlias
reviewed
Nov 13, 2023
Contributor
Author
|
@dashpole What should I do with changelog and matrix? |
Contributor
|
I don't think this needs to be in the matrix. You can add to the changelog under |
MrAlias
reviewed
Nov 13, 2023
Contributor
Author
|
@dashpole Updated changelog |
Contributor
Author
|
@MrAlias Can you take another look? |
MrAlias
approved these changes
Nov 13, 2023
jack-berg
reviewed
Nov 13, 2023
Contributor
|
Please be sure to update the PR title. |
Co-authored-by: jack-berg <[email protected]>
asafm
changed the title
cijothomas
reviewed
Nov 14, 2023
dashpole
reviewed
Nov 20, 2023
Co-authored-by: David Ashpole <[email protected]>
dashpole
approved these changes
Nov 21, 2023
Contributor
Author
|
@cijothomas Can I resolve the conversation? |
cijothomas
approved these changes
Nov 22, 2023
jesusvazquez
approved these changes
Nov 22, 2023
Contributor
Author
|
@cijothomas Who else is needed to approve? |
1 task
Member
I am not an owner to merge this, but I think its best to get another round of review from @jack-berg and @arminru who reviewed this PR earlier! |
jack-berg
approved these changes
Nov 22, 2023
Member
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Small recommendations I think would improve the readability but content looks good.
Co-authored-by: jack-berg <[email protected]>
Co-authored-by: jack-berg <[email protected]>
Co-authored-by: jack-berg <[email protected]>
Contributor
Author
|
@jack-berg Ready to merge 🎉 |
codeboten
approved these changes
Nov 23, 2023
jmacd
approved these changes
Nov 24, 2023
Contributor
Author
|
@carlosalberto @dashpole Ready to merge |
12 tasks
This was referenced Jan 3, 2024
6 tasks
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…utes (open-telemetry#3761) Fixes open-telemetry#3705 ## Changes Allowing exporters (e.g. Prometheus exporter) to add the resource attributes to each exported metric attributes
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3705
Changes
Allowing exporters (e.g. Prometheus exporter) to add the resource attributes to each exported metric attributes
CHANGELOG.mdfile updated for non-trivial changesspec-compliance-matrix.mdupdated if necessary