Skip to content

add console as a supported env variable exporter type#3742

Merged
carlosalberto merged 8 commits intoopen-telemetry:mainfrom
codeboten:codeboten/env-var-exporters-console
Nov 27, 2023
Merged

add console as a supported env variable exporter type#3742
carlosalberto merged 8 commits intoopen-telemetry:mainfrom
codeboten:codeboten/env-var-exporters-console

Conversation

@codeboten
Copy link
Copy Markdown
Contributor

@codeboten codeboten commented Oct 26, 2023

Changes

This PR is a follow up to #3740 and #3741. As some languages (the ones I looked at were: python, js, ruby) already support the console type of exporter, I thought it would be good if the spec confirmed it.

Keeping in draft until the other PRs are reviewed.

codeboten pushed a commit to codeboten/opentelemetry-go-contrib that referenced this pull request Oct 26, 2023
support console key in trace/metric exporter env var config
51ee3a1 
This adds support for the standard output exporter for traces and metrics. To remain consistent with other implementations, i used the key `console` as the identifier for the exporter. This change is related to the specification pull request open-telemetry/opentelemetry-specification#3742

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten mentioned this pull request Oct 26, 2023
Merged
@codeboten codeboten mentioned this pull request Oct 28, 2023
Closed
pellared
pellared reviewed Oct 30, 2023
View reviewed changes
Comment thread CHANGELOG.md
Comment thread CHANGELOG.md
pellared
pellared approved these changes Oct 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the changelog entry should be moved

tylerbenson
tylerbenson reviewed Oct 30, 2023
View reviewed changes
Comment thread specification/configuration/sdk-environment-variables.md Outdated
@codeboten
Copy link
Copy Markdown
Contributor Author

codeboten commented Oct 30, 2023

Note to reviewers that console is used in python, js, ruby. Java uses logging but after a brief chat w/ @jack-berg, he suggested adding an alias for console in java would be trivial.

codeboten pushed a commit to codeboten/opentelemetry-go-contrib that referenced this pull request Nov 1, 2023
support console key in trace/metric exporter env var config
0eca1c9 
This adds support for the standard output exporter for traces and metrics. To remain consistent with other implementations, i used the key `console` as the identifier for the exporter. This change is related to the specification pull request open-telemetry/opentelemetry-specification#3742

Signed-off-by: Alex Boten <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 7, 2023

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Nov 7, 2023
@codeboten
Copy link
Copy Markdown
Contributor Author

codeboten commented Nov 7, 2023

Not stale, but still blocked by #3740 and #3741.

@github-actions github-actions Bot removed the Stale label Nov 8, 2023
@codeboten codeboten mentioned this pull request Nov 8, 2023
Merged
1 task
@svrnm
Copy link
Copy Markdown
Member

svrnm commented Nov 8, 2023

For completness:

Following the spec compliance matrix the following languages have support for OTEL_TRACES_EXPORTER and besides I listed how an enduser can set the console exporter:

  • Java: logging
  • JS: console
  • Python: console
  • Ruby: console
  • Erlang: no "console" support yet
  • PHP: console

Rust, C++, Go and Swift are listed with not supported/unknown. .NET is also listed as not supported, but the .NET auto instrumentation has the following construct (see https://opentelemetry.io/docs/instrumentation/net/getting-started/ & https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docs/config.md#internal-logs):

OTEL_TRACES_EXPORTER=none \
  OTEL_METRICS_EXPORTER=none \
  OTEL_LOGS_EXPORTER=none \
  OTEL_DOTNET_AUTO_TRACES_CONSOLE_EXPORTER_ENABLED=true \
  OTEL_DOTNET_AUTO_METRICS_CONSOLE_EXPORTER_ENABLED=true \
  OTEL_DOTNET_AUTO_LOGS_CONSOLE_EXPORTER_ENABLED=true

@pellared
Copy link
Copy Markdown
Member

pellared commented Nov 8, 2023 •
edited
Loading

Go will add support for console via autoexport thanks to open-telemetry/opentelemetry-go-contrib#4486 (not released yet)

@dnutels dnutels mentioned this pull request Nov 9, 2023
Closed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 16, 2023

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Nov 16, 2023
@jack-berg jack-berg removed the Stale label Nov 16, 2023
jack-berg
jack-berg reviewed Nov 17, 2023
View reviewed changes
Comment thread specification/configuration/sdk-environment-variables.md
Alex Boten added 2 commits November 20, 2023 20:55
add console as a supported env variable exporter type
0a1ee5e 
This PR is a follow up to open-telemetry#3740 and open-telemetry#3741. As some languages (the ones I looked at were: python, js, ruby) already support the `console` type of exporter, I thought it would be good if the spec confirmed it.

Signed-off-by: Alex Boten <[email protected]>
add note about logging keyword
1fcefba 
Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten force-pushed the codeboten/env-var-exporters-console branch from 15892d7 to 1fcefba Compare November 21, 2023 04:58
@codeboten codeboten marked this pull request as ready for review November 21, 2023 04:59
@codeboten codeboten requested review from a team November 21, 2023 04:59
pellared
pellared approved these changes Nov 21, 2023
View reviewed changes
Comment thread specification/configuration/sdk-environment-variables.md Outdated
MrAlias
MrAlias reviewed Nov 27, 2023
View reviewed changes
Comment thread specification/configuration/sdk-environment-variables.md Outdated
Comment thread specification/configuration/sdk-environment-variables.md Outdated
Comment thread specification/configuration/sdk-environment-variables.md Outdated
@carlosalberto carlosalberto merged commit d72b0da into open-telemetry:main Nov 27, 2023
@jack-berg jack-berg mentioned this pull request Nov 29, 2023
Merged
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
add console as a supported env variable exporter type (open-telemetry…
bb83aeb 
…#3742)

## Changes

This PR is a follow up to
open-telemetry#3740
and
open-telemetry#3741.
As some languages (the ones I looked at were: python, js, ruby) already
support the `console` type of exporter, I thought it would be good if
the spec confirmed it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosalberto carlosalberto carlosalberto approved these changes

@pellared pellared pellared approved these changes

@MrAlias MrAlias MrAlias approved these changes

@jack-berg jack-berg jack-berg approved these changes

+1 more reviewer

@tylerbenson tylerbenson tylerbenson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yurishkuro yurishkuro

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@codeboten @svrnm @pellared @carlosalberto @tylerbenson @MrAlias @jack-berg @yurishkuro