Clarify how ObservedTimestamp field is set if unspecified#3385
Merged
jack-berg merged 2 commits intoopen-telemetry:mainfrom Apr 14, 2023
Merged
Conversation
jack-berg
reviewed
Apr 12, 2023
reyang
reviewed
Apr 12, 2023
trask
reviewed
Apr 12, 2023
25 tasks
tigrannajaryan
force-pushed
the
feature/tigran/clarify-observedtimestamp
branch
from
e44fd55 to
1d5adb1
Compare
Member
Author
|
@reyang @jack-berg @djaglowski PR updated, please take another look. |
jack-berg
approved these changes
Apr 14, 2023
reyang
reviewed
Apr 14, 2023
reyang
approved these changes
Apr 14, 2023
Member
reyang
left a comment
reyang
left a comment
There was a problem hiding this comment.
LGTM with a non-blocking comment.
This is a clarification that follows from how the data model is specified: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md#field-observedtimestamp This was noticed in a comment on another PR: https://github.com/open-telemetry/opentelemetry-specification/pull/3383/files#r1164491423
tigrannajaryan
force-pushed
the
feature/tigran/clarify-observedtimestamp
branch
from
1d5adb1 to
d29bdef
Compare
trask
approved these changes
Apr 14, 2023
djaglowski
approved these changes
Apr 14, 2023
4 tasks
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…etry#3385) This is a clarification that follows from how the data model is specified: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md#field-observedtimestamp This was noticed in a comment on another PR: https://github.com/open-telemetry/opentelemetry-specification/pull/3383/files#r1164491423 Co-authored-by: jack-berg <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a clarification that follows from how the data model is specified: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md#field-observedtimestamp
This was noticed in a comment on another PR:
https://github.com/open-telemetry/opentelemetry-specification/pull/3383/files#r1164491423