Skip to content

Reorganize specification related to OTLP file exporter#3031

Merged
tigrannajaryan merged 6 commits intoopen-telemetry:mainfrom
alanwest:alanwest/otlp-file-exporter-reorg
Jan 3, 2023
Merged

Reorganize specification related to OTLP file exporter#3031
tigrannajaryan merged 6 commits intoopen-telemetry:mainfrom
alanwest:alanwest/otlp-file-exporter-reorg

Conversation

@alanwest
Copy link
Copy Markdown
Member

Fixes #3003
Contributes to #2911

Changes

This PR moves and reorganizes parts of the specification relevant to exporting OTLP data to a file.

  • Removes the "Build-in exporters" section from the Log SDK. The OTLP exporter has its own specification covering all signals. The part regarding a file exporter is not unique to logs. Exporting OTLP data to a file is also applicable to trace and metric data.
  • Moves the file describing OTLP JSON serialization under the protocol subdirectory. As discussed in the Logs SIG (12/7/2022), this file provides a foundation for further progress on specifying an OTLP file exporter.

@alanwest alanwest requested review from a team December 13, 2022 21:51
@alanwest alanwest changed the title Alanwest/otlp file exporter reorg Reorganize specification related to OTLP file exporter Dec 13, 2022
Copy link
Copy Markdown
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Java already has exporters that log in OTLP JSON format (e.g. OtlpJsonLoggingSpanExporter).

Comment thread specification/logs/sdk.md
@arminru arminru added spec:logs Related to the specification/logs directory area:sdk Related to the SDK labels Dec 19, 2022
@github-actions
Copy link
Copy Markdown

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@tigrannajaryan tigrannajaryan merged commit 56c20c2 into open-telemetry:main Jan 3, 2023
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
…y#3031)

Fixes open-telemetry#3003 
Contributes to open-telemetry#2911

## Changes

This PR moves and reorganizes parts of the specification relevant to exporting OTLP data to a file.

* Removes the "Build-in exporters" section from the Log SDK. The OTLP exporter has its own specification covering all signals. The part regarding a file exporter is not unique to logs. Exporting OTLP data to a file is also applicable to trace and metric data.
* Moves the file describing OTLP JSON serialization under the `protocol` subdirectory. As discussed in the Logs SIG (12/7/2022), this file provides a foundation for further progress on specifying an OTLP file exporter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:sdk Related to the SDK spec:logs Related to the specification/logs directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove "Built-in exporters" section in Log SDK

6 participants