Make messaging context propagation requirements explicit#2750
Make messaging context propagation requirements explicit#2750reyang merged 15 commits intoopen-telemetry:mainfrom
Conversation
Co-authored-by: Georg Pirklbauer <[email protected]>
joaopgrassi
changed the title
lmolkova
left a comment
lmolkova
left a comment
There was a problem hiding this comment.
Left a small comment, but looks good overall!
reyang
added
area:semantic-conventions
pyohannes
left a comment
pyohannes
left a comment
There was a problem hiding this comment.
One small request, otherwise this looks good to me.
dpauls
left a comment
dpauls
left a comment
There was a problem hiding this comment.
Overall, I'm happy with these changes. I had one small suggestion regarding the term "batch", which would be nice to address, but I am willing to approve even if we don't define the term.
joaopgrassi
requested review from
brunobat,
lmolkova and
pyohannes
and removed request for
brunobat
ppatierno
left a comment
ppatierno
left a comment
There was a problem hiding this comment.
Sorry to be late on this, but I left a comment.
| The consumer receives, processes, and settles a message. "Receiving" is the | ||
| process of obtaining a message from the intermediary, "processing" is the | ||
| process of acting on the information a message contains, "settling" is the | ||
| process of notifying an intermediary that a message was processed successfully. |
There was a problem hiding this comment.
Is "settling" really the notification about the message to be processed?
In general, the intermediary is only interested to know that the message was delivered to the consumer so on "receiving" it should be settled.
Processing the message is part of the "contract" between producer and consumer, so that by using a request-reply pattern and a "reply-to" address/queue/topic, the consumer can notify (via a new message) to the producer that the processing happened.
10 participants
Fixes #2749
Changes
Related OTEP #205
This PR integrates the Context propagation section from the OTEP into the trace messaging semantic conventions.
I did some slight modification on the text, just to give more context on the "problem" and why this change is necessary. The core concept of the OTEP is still maintained of course.