Skip to content

Sampling SDK spec is outdated (and wrong by now) #634

@Oberon00

Description

@Oberon00

See https://github.com/open-telemetry/opentelemetry-specification/blob/1729bc4337bdc1df83ff7eab53eb7405d6e75665/specification/trace/sdk.md#sampling

Sampling may be implemented on different stages of a trace collection. OpenTelemetry API defines a Sampler interface that can be used at instrumentation points by libraries to check the SamplingResult early and optimize the amount of telemetry that needs to be collected.

This is wrong, since samplers are an SDK concept and thus cannot (or at least should not) be used by instrumentations. Also, there is no mention of the TracerProvider having a sampler asssociated with it, or the tracer automatically checking the sampler when starting a span.

Metadata

Metadata

Assignees

Labels

area:samplingRelated to trace samplingarea:sdkRelated to the SDKpriority:p1Highest priority levelrelease:required-for-gaMust be resolved before GA release, or nice to have before GAspec:traceRelated to the specification/trace directory

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions