-
Notifications
You must be signed in to change notification settings - Fork 976
Sampling SDK spec is outdated (and wrong by now) #634
Copy link
Copy link
Closed
Labels
area:samplingRelated to trace samplingRelated to trace samplingarea:sdkRelated to the SDKRelated to the SDKpriority:p1Highest priority levelHighest priority levelrelease:required-for-gaMust be resolved before GA release, or nice to have before GAMust be resolved before GA release, or nice to have before GAspec:traceRelated to the specification/trace directoryRelated to the specification/trace directory
Metadata
Metadata
Assignees
Labels
area:samplingRelated to trace samplingRelated to trace samplingarea:sdkRelated to the SDKRelated to the SDKpriority:p1Highest priority levelHighest priority levelrelease:required-for-gaMust be resolved before GA release, or nice to have before GAMust be resolved before GA release, or nice to have before GAspec:traceRelated to the specification/trace directoryRelated to the specification/trace directory
See https://github.com/open-telemetry/opentelemetry-specification/blob/1729bc4337bdc1df83ff7eab53eb7405d6e75665/specification/trace/sdk.md#sampling
This is wrong, since samplers are an SDK concept and thus cannot (or at least should not) be used by instrumentations. Also, there is no mention of the TracerProvider having a sampler asssociated with it, or the tracer automatically checking the sampler when starting a span.