Skip to content

no pool.name in mysql (javascript) #2958

@haddasbronfman

Description

@haddasbronfman

What are you trying to achieve?
I wanted to implement this metric https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/database-metrics.md#connection-pools and add the attribute pool.name for MySQL DB in javascript.

What did you expect to see?
I expected that the MySQL library will have a field that identifies the pool. something like a name/id that distinguishes it from other pools.

Since there is no such field I wonder what should I do - should I create such an identifier myself? It will cause a weird situation where the user sees an attribute like pool.name=4 that he didn't declare by himself...

the code of the pool in Mysql is here: https://github.com/mysqljs/mysql/blob/master/index.js#L22
You can see the it is possible to give a ConnectionConfig when creating the pool, but I can’t find any ‘ID’ or 'name' field in this object: https://github.com/mysqljs/mysql/blob/dc9c152a87ec51a1f647447268917243d2eab1fd/lib/ConnectionConfig.js#L12

Metadata

Metadata

Labels

area:semantic-conventionsRelated to semantic conventionsspec:metricsRelated to the specification/metrics directory

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions