Skip to content

Move time from DataPoint to Histogram/ExpoHistogram#2411

Merged
cijothomas merged 1 commit into
open-telemetry:mainfrom
fraillt:move-time-from-data-point-to-histogram-expo-histogram
Dec 11, 2024
Merged

Move time from DataPoint to Histogram/ExpoHistogram#2411
cijothomas merged 1 commit into
open-telemetry:mainfrom
fraillt:move-time-from-data-point-to-histogram-expo-histogram

Conversation

@fraillt

@fraillt fraillt commented Dec 11, 2024

Copy link
Copy Markdown
Contributor

Fixes #1566.

Changes

Move time and start_time fields from DataPoint to specific aggregations, - Histogram and ExponentialHistogram.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@fraillt
fraillt requested a review from a team as a code owner December 11, 2024 05:59
@codecov

codecov Bot commented Dec 11, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 71.42857% with 22 lines in your changes missing coverage. Please review.

Project coverage is 79.2%. Comparing base (1a4e931) to head (c105ed6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-stdout/src/metrics/exporter.rs 0.0% 12 Missing ⚠️
opentelemetry-proto/src/transform/metrics.rs 0.0% 4 Missing ⚠️
...-sdk/src/metrics/internal/exponential_histogram.rs 86.6% 4 Missing ⚠️
...etry-sdk/src/testing/metrics/in_memory_exporter.rs 66.6% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #2411     +/-   ##
=======================================
- Coverage   79.3%   79.2%   -0.1%     
=======================================
  Files        122     122             
  Lines      21511   21516      +5     
=======================================
- Hits       17060   17059      -1     
- Misses      4451    4457      +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fraillt fraillt mentioned this pull request Dec 11, 2024
Merged
4 tasks
@cijothomas
cijothomas merged commit e4cba94 into open-telemetry:main Dec 11, 2024
@fraillt
fraillt deleted the move-time-from-data-point-to-histogram-expo-histogram branch December 13, 2024 06:27
takumi-earth pushed a commit to earthlings-dev/opentelemetry-rust that referenced this pull request Jan 27, 2026
@fraillt
Move time from DataPoint to Histogram/ExpoHistogram (open-telemetry#2411
45011a3 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cijothomas cijothomas cijothomas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Memory optimization for metric datapoints

2 participants

@fraillt @cijothomas