Bump MSRV to 1.70#2179
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2179 +/- ##
=====================================
Coverage 79.0% 79.0%
=====================================
Files 121 121
Lines 20945 20945
=====================================
+ Hits 16559 16561 +2
+ Misses 4386 4384 -2 ☔ View full report in Codecov by Sentry. |
|
|
||
| ## vNext | ||
|
|
||
| - Bump MSRV to 1.70 [#2179](https://github.com/open-telemetry/opentelemetry-rust/pull/2179) |
There was a problem hiding this comment.
this can be skipped as otlp is already on 1.71.1
|
|
||
| ## vNext | ||
|
|
||
| - Bump MSRV to 1.70 [#2179](https://github.com/open-telemetry/opentelemetry-rust/pull/2179) |
There was a problem hiding this comment.
please skip this, as proto is already on 1.71.1
cijothomas
left a comment
cijothomas
left a comment
There was a problem hiding this comment.
Thanks.
(Need a minor cleanup in changelog for proto, otlp which are already on higher version)
| license = "Apache-2.0" | ||
| edition = "2021" | ||
| rust-version = "1.65" | ||
| rust-version = "1.70" |
There was a problem hiding this comment.
Nit - Also update the Readme.md. Not related to this PR and to be handled separately, we need to be consistent regarding mentioning or not-mentioning msrv in Readme.md for all the otel crates.
|
Thanks for the PR. LGTM with nit comments. There are few places for msrv patching and version pinning, which can be cleaned up now. I will raise a separate PR for that. |
|
Merging. The nits can be fixed as part of cleanups required in the patch scipts. |
Co-authored-by: Cijo Thomas <[email protected]>
Co-authored-by: Cijo Thomas <[email protected]>
3 participants
As discussed in #2168.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes