Export event-name in OTLP Exporter optionally, if the feature-flag is enabled#1994
Merged
Merged
Conversation
cijothomas
reviewed
Aug 7, 2024
cijothomas
reviewed
Aug 7, 2024
cijothomas
reviewed
Aug 7, 2024
cijothomas
reviewed
Aug 7, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1994 +/- ##
=======================================
- Coverage 75.1% 75.1% -0.1%
=======================================
Files 122 122
Lines 20642 20642
=======================================
- Hits 15505 15503 -2
- Misses 5137 5139 +2 ☔ View full report in Codecov by Sentry. |
utpilla
reviewed
Aug 8, 2024
cijothomas
reviewed
Aug 8, 2024
cijothomas
approved these changes
Aug 8, 2024
cijothomas
left a comment
cijothomas
left a comment
Member
There was a problem hiding this comment.
LGTM, please add changelog for stdout too.
utpilla
reviewed
Aug 8, 2024
utpilla
approved these changes
Aug 8, 2024
Member
Author
done. |
takumi-earth
pushed a commit
to earthlings-dev/opentelemetry-rust
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1941
Changes
Added feature flag
populate-logs-event-nameinopentelemetry-protoandopentelemetry-otlpcrates. The feature flag in theopentelemetry-protocrate will be enabled when it is explicitly enabled for theopentelemetry-otlpcrate. And this will result inLogRecord::event_nameto be populated in the OTLP log attributes.TBD - Update Changelog.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes