Fix StatusCode in stdout exporter (#1453)#1454
Merged
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1454 +/- ##
=====================================
Coverage 60.8% 60.8%
=====================================
Files 146 146
Lines 19230 19230
=====================================
+ Hits 11702 11711 +9
+ Misses 7528 7519 -9 ☔ View full report in Codecov by Sentry. |
lalitb
reviewed
Dec 29, 2023
| opentelemetry::trace::Status::Error { description } => Status { | ||
| message: Some(description), | ||
| code: 1, | ||
| code: 2, |
Member
There was a problem hiding this comment.
Nit- should we use the constants for status codes for better readability?
const STATUS_CODE_UNSET: u32 = 0;
const STATUS_CODE_OK: u32 = 1;
const STATUS_CODE_ERROR: u32 = 2;These constants can be used both in is_zero and From.
takumi-earth
pushed a commit
to earthlings-dev/opentelemetry-rust
that referenced
this pull request
Jan 27, 2026
…ry#1454) Fixes open-telemetry#1453 ## Changes Swap the ordinals to match the spec. Co-authored-by: Lalit Kumar Bhasin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1453
Changes
Swap the ordinals to match the spec.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes