Skip to content

opentelemetry-instrumentation-dbapi: Add Database client operation duration and returned rows metrics#4481

Merged
xrmx merged 10 commits into
open-telemetry:mainfrom
herin049:feat/dbapi-metrics
May 15, 2026
Merged

opentelemetry-instrumentation-dbapi: Add Database client operation duration and returned rows metrics#4481
xrmx merged 10 commits into
open-telemetry:mainfrom
herin049:feat/dbapi-metrics

Conversation

@herin049

@herin049 herin049 commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Description

Adds support for client operation duration and returned row metrics when Semconv opt-in is enabled for Database semantic conventions.

Fixes #4480

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

uv run tox -e py314-test-instrumentation-dbapi

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@herin049
herin049 requested a review from a team as a code owner April 23, 2026 02:37
@herin049 herin049 moved this to Ready for review in Python PR digest Apr 23, 2026
@github-project-automation github-project-automation Bot moved this from Ready for review to Approved PRs in Python PR digest Apr 27, 2026
@tammy-baylis-swi

tammy-baylis-swi commented May 9, 2026

Copy link
Copy Markdown
Contributor

Great to see some metrics added! Though this partially overlaps with the semconv stuff I have in #4109 Not sure how to proceed. 🤔

@herin049

herin049 commented May 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Great to see some metrics added! Though this partially overlaps with the semconv stuff I have in #4109 Not sure how to proceed. 🤔

@tammy-baylis-swi I don't think there will be too many conflicts, I can rebase my changes on top of yours when your changes are merged in.

@tammy-baylis-swi

tammy-baylis-swi commented May 12, 2026

Copy link
Copy Markdown
Contributor

@tammy-baylis-swi I don't think there will be too many conflicts, I can rebase my changes on top of yours when your changes are merged in.

Thank you @herin049 🙏 #4109 has been merged to main.

@emdneto

emdneto commented May 12, 2026

Copy link
Copy Markdown
Member

Thanks for the PR!

Just a heads-up: we no longer update CHANGELOG.md directly. The changelog is now generated from changelog fragments using Towncrier.

Please add the appropriate changelog fragment for this change instead of editing CHANGELOG.md manually. You can find the instructions and expected format in CONTRIBUTING.md.

@aabmass aabmass moved this from Approved PRs to Ready for merge in Python PR digest May 14, 2026
@aabmass
aabmass added this pull request to the merge queue May 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks May 14, 2026
xrmx
xrmx reviewed May 14, 2026
View reviewed changes
Comment thread .changelog/4481.added Outdated
tammy-baylis-swi
tammy-baylis-swi approved these changes May 14, 2026
View reviewed changes

@tammy-baylis-swi tammy-baylis-swi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@aabmass aabmass moved this from Ready for merge to Approved PRs that need fixes in Python PR digest May 14, 2026
@github-project-automation github-project-automation Bot moved this from Approved PRs that need fixes to Approved PRs in Python PR digest May 15, 2026
@xrmx xrmx moved this from Approved PRs to Ready for merge in Python PR digest May 15, 2026
@xrmx
xrmx enabled auto-merge (squash) May 15, 2026 13:52
@xrmx
xrmx merged commit 390116f into open-telemetry:main May 15, 2026
1496 of 1498 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for merge to Done in Python PR digest May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrmx xrmx xrmx approved these changes
@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes
@tammy-baylis-swi tammy-baylis-swi tammy-baylis-swi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Python PR digest
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Metrics to "opentelemetry-instrumentation-dbapi"

6 participants

@herin049 @tammy-baylis-swi @emdneto @xrmx @MikeGoldsmith @aabmass