Add support for process.disk.io metric in system-metrics instrumentation#4397
Conversation
MikeGoldsmith
left a comment
MikeGoldsmith
left a comment
There was a problem hiding this comment.
Thanks @Manvi2402 - the changes looks pretty good. I've left some suggestions we should do be fore accepting.
github-project-automation
Bot
moved this to Reviewed PRs that need fixes
in Python PR digest
Co-authored-by: Mike Goldsmith <[email protected]>
|
Thanks for the suggestions @MikeGoldsmith . I've applied all the requested changes. Please let me know if anything else needs improvement. |
github-project-automation
Bot
moved this from Reviewed PRs that need fixes
to Approved PRs
in Python PR digest
|
Overall looks good, thank you for another fix @Manvi2402 ! Please could you |
|
Thank you for the review @tammy-baylis-swi . I've run tox -e precommit to fix the indentation issues and pushed the changes. |
tammy-baylis-swi
left a comment
tammy-baylis-swi
left a comment
There was a problem hiding this comment.
Thanks again @Manvi2402 ! Please just remove those extra Changelog lines
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
4 participants
Description
Adds support for the
process.disk.iometric toopentelemetry-instrumentation-system-metrics.Fixes #3647
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added unit tests for
process.disk.io:test_process_disk_io— verifies read_bytes and write_bytes are collected correctlytest_process_disk_io_not_implemented_error— verifies graceful handling on platforms whereio_counters()is unavailable (e.g. macOS)Run locally with:
pytest tests/test_system_metrics.py -v -k "disk_io or process_metrics_instrument"
Result: 42 passed, 1 skipped, 0 failed
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.