refactor(docker-tests): replace SpanAttributes with semconv attributes#4339
Merged
xrmx merged 7 commits intoopen-telemetry:mainfrom Mar 19, 2026
Merged
Conversation
xrmx
approved these changes
Mar 19, 2026
xrmx
moved this from Easy to review / merge / close
to Approved PRs
in Python PR digest
This was referenced Mar 25, 2026
7 tasks
Copilot AI
added a commit
to 123liuziming/opentelemetry-python-contrib
that referenced
this pull request
Mar 30, 2026
…#4339 cleanup Agent-Logs-Url: https://github.com/123liuziming/opentelemetry-python-contrib/sessions/25f73137-1606-4050-b879-ffc01d7ab803 Co-authored-by: 123liuziming <[email protected]>
123liuziming
added a commit
to 123liuziming/opentelemetry-python-contrib
that referenced
this pull request
Mar 30, 2026
…tests-cleanup Revert docker-test formatting changes that undo merged open-telemetry#4339 cleanup
xrmx
added a commit
that referenced
this pull request
Apr 20, 2026
…rios. (#4341) * Initial plan * Clean up _ENVIRON_ACTIVATION_KEY and _ENVIRON_TOKEN in _teardown_request to prevent duplicate execution Add a finally block in _teardown_request to pop _ENVIRON_ACTIVATION_KEY and _ENVIRON_TOKEN from flask.request.environ after teardown completes. This prevents issues when _teardown_request is called multiple times, as the second call will see activation as None and return early. Co-authored-by: 123liuziming <[email protected]> * Improve test to explicitly verify duplicate teardown calls don't cause errors Co-authored-by: 123liuziming <[email protected]> * fix lint Change-Id: Iea7711d86dcd6f4da7a3af92cb68db2fe3db345f Co-developed-by: Cursor <[email protected]> * polish CHANGELOG Change-Id: Ie89cac244ade8d04768503112db8673f91d81756 Co-developed-by: Cursor <[email protected]> * Refactor request teardown to avoid duplicate cleanup Remove redundant environment variable cleanup in finally block. * Update test_flask_compatibility.py * Uncomment FlaskInstrumentor import in test file * Initial plan * Fix ruff format errors in docker test files Co-authored-by: 123liuziming <[email protected]> Agent-Logs-Url: https://github.com/123liuziming/opentelemetry-python-contrib/sessions/9165702c-5648-474d-9291-dfa57008b0b6 * Initial plan * Revert docker-test formatting changes that undo merged #4339 cleanup Agent-Logs-Url: https://github.com/123liuziming/opentelemetry-python-contrib/sessions/25f73137-1606-4050-b879-ffc01d7ab803 Co-authored-by: 123liuziming <[email protected]> * Update CHANGELOG.md --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Emídio Neto <[email protected]> Co-authored-by: Mike Goldsmith <[email protected]> Co-authored-by: Riccardo Magliocchetti <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3475
Description
Replaces usage of deprecated
SpanAttributesfromopentelemetry.semconv.tracewith the preferred imports from
opentelemetry.semconv._incubating.attributesin the docker-tests package.
Files changed:
Type of change