Skip to content

opentelemetry-instrumentation-aws-lambda: fix improper handling of header casing#4216

Merged
aabmass merged 16 commits into
open-telemetry:mainfrom
herin049:fix/aws-lambda-header-casing
May 14, 2026
Merged

opentelemetry-instrumentation-aws-lambda: fix improper handling of header casing#4216
aabmass merged 16 commits into
open-telemetry:mainfrom
herin049:fix/aws-lambda-header-casing

Conversation

@herin049

@herin049 herin049 commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes issue where request headers are extracted in a case-sensitive manner, resulting in issues with context propagation for API Gateway requests.

Fixes #4106

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

tox run -e $(tox --listenvs | grep opentelemetry-aws-lambda | tr '\n' ',')

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added

@herin049
herin049 requested a review from a team as a code owner February 19, 2026 03:41
xrmx
xrmx reviewed Feb 20, 2026
View reviewed changes
Comment thread ...elemetry-instrumentation-aws-lambda/src/opentelemetry/instrumentation/aws_lambda/__init__.py
Comment thread ...elemetry-instrumentation-aws-lambda/src/opentelemetry/instrumentation/aws_lambda/__init__.py Outdated
@herin049
herin049 requested review from emdneto and xrmx February 21, 2026 03:59
@herin049

herin049 commented Feb 21, 2026

Copy link
Copy Markdown
Contributor Author

I've opted to add a CIDict to opentelemetry-instrumentation, since this will likely have uses elsewhere and is not limited to just HTTP.

@tammy-baylis-swi tammy-baylis-swi moved this to Ready for review in Python PR digest Feb 26, 2026
MikeGoldsmith
MikeGoldsmith approved these changes Mar 6, 2026
View reviewed changes

@MikeGoldsmith MikeGoldsmith left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've left a couple of non-blocking suggestions for the CIDict class.

Comment thread opentelemetry-instrumentation/src/opentelemetry/instrumentation/cidict.py Outdated
@herin049
herin049 requested a review from MikeGoldsmith March 6, 2026 21:40
@herin049
herin049 force-pushed the fix/aws-lambda-header-casing branch from 823f53c to 2bdf34b Compare April 4, 2026 03:47
@MikeGoldsmith MikeGoldsmith moved this from Ready for review to Approved PRs in Python PR digest Apr 8, 2026
@aabmass

aabmass commented May 7, 2026

Copy link
Copy Markdown
Member

Good to close the open conversation threads?

@aabmass
aabmass enabled auto-merge (squash) May 7, 2026 17:56
@aabmass
aabmass disabled auto-merge May 7, 2026 17:57
@herin049

herin049 commented May 7, 2026

Copy link
Copy Markdown
Contributor Author

Good to close the open conversation threads?

@aabmass I think so. @xrmx do you want to take another look quick?

herin049 and others added 3 commits May 7, 2026 14:14
@herin049
Update license comments to SPDX format
4ea5d56 
Replaced Apache License comments with SPDX identifier.
@herin049
Update license information in cidict.py
e726c9e 
Removed Apache License comments and added SPDX identifier.
@aabmass
Merge branch 'main' into fix/aws-lambda-header-casing
bdb10c3
@aabmass
aabmass enabled auto-merge (squash) May 8, 2026 20:06
@aabmass aabmass moved this from Approved PRs to Ready for merge in Python PR digest May 8, 2026
@aabmass
aabmass disabled auto-merge May 8, 2026 21:06
@aabmass
aabmass enabled auto-merge (squash) May 8, 2026 21:06
@emdneto

emdneto commented May 12, 2026

Copy link
Copy Markdown
Member

Thanks for the PR!

Just a heads-up: we no longer update CHANGELOG.md directly. The changelog is now generated from changelog fragments using Towncrier.

Please add the appropriate changelog fragment for this change instead of editing CHANGELOG.md manually. You can find the instructions and expected format in CONTRIBUTING.md.

xrmx
xrmx approved these changes May 13, 2026
View reviewed changes

@xrmx xrmx left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to move to changelog fragment

@github-project-automation github-project-automation Bot moved this from Ready for merge to Approved PRs in Python PR digest May 13, 2026
@xrmx
xrmx disabled auto-merge May 13, 2026 09:13
@xrmx
xrmx enabled auto-merge (squash) May 13, 2026 09:13
@xrmx xrmx moved this from Approved PRs to Ready for merge in Python PR digest May 13, 2026
@xrmx
xrmx added this pull request to the merge queue May 13, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks May 13, 2026
@aabmass
aabmass added this pull request to the merge queue May 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks May 14, 2026
@aabmass
aabmass merged commit 65a1134 into open-telemetry:main May 14, 2026
751 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for merge to Done in Python PR digest May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabmass aabmass aabmass approved these changes
@xrmx xrmx xrmx approved these changes
@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes
@emdneto emdneto Awaiting requested review from emdneto

Assignees

No one assigned

Labels

None yet

Projects

Python PR digest
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

W3CBaggagePropagator fails to extract baggage when header name is title-cased (e.g., "Baggage" vs "baggage")

6 participants

@herin049 @aabmass @emdneto @xrmx @MikeGoldsmith @tammy-baylis-swi