Skip to content

feat: add support for aiobotocore instrumentation#4049

Merged
xrmx merged 14 commits intoopen-telemetry:mainfrom
herin049:feat/aiobotocore-instrumentation
Mar 19, 2026
Merged

feat: add support for aiobotocore instrumentation#4049
xrmx merged 14 commits intoopen-telemetry:mainfrom
herin049:feat/aiobotocore-instrumentation

Conversation

@herin049
Copy link
Copy Markdown
Contributor

@herin049 herin049 commented Dec 23, 2025 •
edited
Loading

Description

Adds support for aiobotocore instrumentation, following the implementation approach outlined in issue #4048.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests have been added.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@herin049 herin049 changed the title feat: add support for aiobotocore instrumentation (WIP) feat: add support for aiobotocore instrumentation Dec 25, 2025
@herin049 herin049 requested a review from a team as a code owner December 25, 2025 06:48
@xrmx
Copy link
Copy Markdown
Contributor

xrmx commented Dec 31, 2025

@lukeina2z @yiyuan-he wdyt?

xrmx
xrmx reviewed Dec 31, 2025
View reviewed changes
Comment thread ...opentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/package.py Outdated
Comment thread instrumentation/opentelemetry-instrumentation-botocore/pyproject.toml
Comment thread ...y-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/__init__.py
@xrmx xrmx moved this to Ready for review in Python PR digest Dec 31, 2025
@herin049 herin049 force-pushed the feat/aiobotocore-instrumentation branch 2 times, most recently from d32315b to d93357b Compare January 21, 2026 18:36
@herin049 herin049 requested a review from xrmx January 21, 2026 18:41
emdneto
emdneto reviewed Feb 26, 2026
View reviewed changes
Comment thread instrumentation/opentelemetry-instrumentation-botocore/test-requirements-1.txt Outdated
Comment thread ...rumentation/opentelemetry-instrumentation-botocore/tests/test_aiobotocore_instrumentation.py
emdneto
emdneto reviewed Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can imagine some ways to run tests separately for each package, but it requires some modifications to the tox.ini. In the way this is implemented, we need both packages installed to run tests

@herin049
Copy link
Copy Markdown
Contributor Author

herin049 commented Feb 28, 2026

I can imagine some ways to run tests separately for each package, but it requires some modifications to the tox.ini. In the way this is implemented, we need both packages installed to run tests

botocore is a dependency of aiobotocore so there will never be a scenario where just aiobotocore is installed. I can try to make it so that the tests can be ran with just botocore installed, skipping any aiobotocore related tests.

@herin049 herin049 force-pushed the feat/aiobotocore-instrumentation branch from d93357b to cd347e4 Compare February 28, 2026 22:21
@tammy-baylis-swi
Copy link
Copy Markdown
Contributor

tammy-baylis-swi commented Mar 2, 2026

Could we also please have quick updates to the README and readthedocs about what's supported

@herin049 herin049 force-pushed the feat/aiobotocore-instrumentation branch from f80ec06 to 3f24703 Compare March 6, 2026 21:08
@herin049
Copy link
Copy Markdown
Contributor Author

herin049 commented Mar 6, 2026

Could we also please have quick updates to the README and readthedocs about what's supported

@tammy-baylis-swi Done!

tammy-baylis-swi
tammy-baylis-swi approved these changes Mar 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Lgtm

@herin049 herin049 force-pushed the feat/aiobotocore-instrumentation branch from a123507 to 6602525 Compare March 13, 2026 02:15
xrmx
xrmx approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of nits but LGTM, thanks!

Comment thread ...pentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py Outdated
Comment thread CHANGELOG.md Outdated
Comment thread instrumentation/opentelemetry-instrumentation-botocore/tests/test_botocore_instrumentation.py Outdated
@xrmx xrmx moved this from Ready for review to Approved PRs that need fixes in Python PR digest Mar 17, 2026
@herin049 herin049 moved this from Approved PRs that need fixes to Easy to review / merge / close in Python PR digest Mar 17, 2026
@herin049
Copy link
Copy Markdown
Contributor Author

herin049 commented Mar 17, 2026

A bunch of nits but LGTM, thanks!

@xrmx Addressed all the comments.

@xrmx xrmx enabled auto-merge (squash) March 19, 2026 09:04
@xrmx xrmx merged commit 6d3bbfb into open-telemetry:main Mar 19, 2026
860 checks passed
@github-project-automation github-project-automation Bot moved this from Easy to review / merge / close to Done in Python PR digest Mar 19, 2026
@vprivat-ads vprivat-ads mentioned this pull request Apr 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrmx xrmx xrmx approved these changes

@tammy-baylis-swi tammy-baylis-swi tammy-baylis-swi approved these changes

@emdneto emdneto Awaiting requested review from emdneto

Assignees

No one assigned

Labels

None yet

Projects

Python PR digest
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@herin049 @xrmx @tammy-baylis-swi @emdneto