The committers listed above are authorized under a signed CLA.

• ✅ login: guillaumep (62fbf84, 2450145)
• ✅ login: xrmx / name: Riccardo Magliocchetti (fe244a0)

It seems from the CI logs that pymssql does not build for pypy3.

Would it be acceptable to disable pypy3 support in the tests for this instrumentation?

Also, the docs fails to build because of this error:

sphinx.errors.SphinxWarning: autodoc: failed to import module 'pymssql' from module 'opentelemetry.instrumentation'; the following exception was raised:
No module named 'pymssql'

I'm trying to figure out my error, can someone experienced with the repo help?

I had to subclass DatabaseApiIntegration to obtain pymssql's connection attributes, as the attributes are not kept by the library in the Connection object. You need to get them from the connect function parameter.

The committers are authorized under a signed CLA.

• ✅ guillaumep (b93ad00)

@guillaumep
Are you still working on this?

@lzchen I was expecting help with the issues I mentioned in the comments above, but since I never got any replies up to now I had put this work aside.

pymssql instrumention is still a feature we want at work (outbox.com), so if I can have proper support regarding my questions I'll be glad to finish this PR.

Let me rebase the PR this week and post back here with the current issues I will have.

@guillaumep
Apologies for that. Usually PRs are not reviewed unless if marked as review (changed to an actual PR). If you would like help with your build issues, feel free to rebase and we can get you the assistance you need.

The committers listed above are authorized under a signed CLA.

• ✅ login: guillaumep (6cabf98)

@lzchen now ready for review!

@guillaumep Thanks for the contribution. Would you be willing to add yourself as an owner for this component under here?

Thanks for the patience on this review. Would you be able to add your name to component-owners.yml?

Thanks for the patience on this review. Would you be able to add your name to component-owners.yml?

For now yes.

@emdneto @lzchen I think I have resolved all items, but let me know.

@guillaumep please run tox -e generate and tox -e generate-workflows . Also no need to squash everything, we squash on merge

@xrmx @emdneto Rebased on main to solve conflict and ran tox as requested.

What would be your recommendation to use the package as long as it has not been published yet @guillaumep ?
Needs to work locally as well as in Docker builds.

What would be your recommendation to use the package as long as it has not been published yet @guillaumep ? Needs to work locally as well as in Docker builds.

There should be a release shortly, in one or two weeks. In the meantime you can use the same technique as I suggested here to produce a package you may manuall install using pip: #394 (comment)

Installing a local package could be done for a Docker build, copying the file to the Docker image then doing a pip install for example. Please ask a question on Stack Overflow or similar forum if you need help with that.