Avoid calls to context.detach with None token#3673
Merged
xrmx merged 4 commits intoopen-telemetry:mainfrom Aug 18, 2025
Merged
Conversation
Contributor
|
Overall lgtm! Please could you add a changelog entry. |
Member
Author
|
@tammy-baylis-swi thanks for your review! I added a change a changelog entry. |
emdneto
approved these changes
Aug 12, 2025
xrmx
approved these changes
Aug 18, 2025
github-project-automation
Bot
moved this from Easy to review / merge / close
to Done
in Python PR digest
sightseeker
added a commit
to sightseeker/opentelemetry-python-contrib
that referenced
this pull request
Mar 11, 2026
* fixes open-telemetry#3351 * Add changelog entry about open-telemetry#3673 --------- Co-authored-by: Emídio Neto <[email protected]> Co-authored-by: Riccardo Magliocchetti <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is guarding calls to
context.detachwithif token:to make sure these calls are using atokenthat is notNone.Fixes #3351
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.