Skip to content

Rename InMemoryLogExporter to InMemoryLogRecordExporter#3589

Merged
xrmx merged 12 commits intoopen-telemetry:mainfrom
hectorhdzg:hectorhdzg/renameinmem
Nov 21, 2025
Merged

Rename InMemoryLogExporter to InMemoryLogRecordExporter#3589
xrmx merged 12 commits intoopen-telemetry:mainfrom
hectorhdzg:hectorhdzg/renameinmem

Conversation

@hectorhdzg
Copy link
Copy Markdown
Member

@hectorhdzg hectorhdzg commented Jun 19, 2025

Description

Rename the following classes to maintain consistency with specs and other languages implementations, only used in tests for this repo.
InMemoryLogExporter to InMemoryLogRecordExporter

Does This PR Require a Core Repo Change?

@xrmx xrmx moved this to Ready for review in Python PR digest Jun 23, 2025
@xrmx xrmx moved this from Ready for review to Reviewed PR that needs fixing in Python PR digest Jun 30, 2025
@hectorhdzg
Copy link
Copy Markdown
Member Author

I removed alias and reverted to original changes; this is not blocking SDK side rename PR anymore so this can be merged when SDK is released, let me know if there is any other feedback.

@xrmx
Copy link
Copy Markdown
Contributor

xrmx commented Jul 2, 2025

I removed alias and reverted to original changes; this is not blocking SDK side rename PR anymore so this can be merged when SDK is released, let me know if there is any other feedback.

While this may be fine for CI, for the genai instrumentations that are not tied to a single opentelemetry version there's no guarantee they are running against latest sdk so we need to handle both or bump the baseline.

From google-genai instrumentation pyproject.toml:

  "opentelemetry-api >=1.31.1, <2",
  "opentelemetry-instrumentation >=0.52b1, <2",
  "opentelemetry-semantic-conventions >=0.52b1, <2"

@xrmx xrmx merged commit 38bc548 into open-telemetry:main Nov 21, 2025
647 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewed PRs that need fixes to Done in Python PR digest Nov 21, 2025
sightseeker added a commit to sightseeker/opentelemetry-python-contrib that referenced this pull request Mar 11, 2026
…ry#3589)

* Rename InMemoryLogExporter to InMemoryLogRecordExporter

* Remove added file

* Update

* Remove alias

* Update

* Added backward compatibility in imports

* Lint

* Lint

* Lint for real this time :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants