Skip to content

refactor(tornado): replaces SpanAttributes by semconv attributes#3582

Merged
xrmx merged 3 commits intoopen-telemetry:mainfrom
f-kanari:refactor/replace-span-attrs
Jun 16, 2025
Merged

refactor(tornado): replaces SpanAttributes by semconv attributes#3582
xrmx merged 3 commits intoopen-telemetry:mainfrom
f-kanari:refactor/replace-span-attrs

Conversation

@f-kanari
Copy link
Copy Markdown
Contributor

Description

Replaces usage of SpanAttributes with opentelemetry.semconv._incubating.attributes.http_attributes and opentelemetry.semconv._incubating.attributes.net_attributes

Refs #3475

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Jun 13, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: f-kanari / name: f-kanari-safie (243a65a, 7667c35)
  • ✅ login: xrmx / name: Riccardo Magliocchetti (c368805)

@github-actions github-actions Bot requested a review from shalevr June 13, 2025 08:04
@f-kanari f-kanari marked this pull request as draft June 13, 2025 08:10
@f-kanari f-kanari marked this pull request as ready for review June 13, 2025 08:59
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 13, 2025
@xrmx xrmx moved this to Easy to review / merge / close in Python PR digest Jun 13, 2025
@xrmx xrmx enabled auto-merge (squash) June 16, 2025 12:06
@xrmx xrmx merged commit 0a03c9a into open-telemetry:main Jun 16, 2025
625 checks passed
@github-project-automation github-project-automation Bot moved this from Easy to review / merge / close to Done in Python PR digest Jun 16, 2025
devmonkey22 added a commit to devmonkey22/opentelemetry-python-contrib that referenced this pull request Jul 9, 2025
xrmx added a commit that referenced this pull request Jul 10, 2025
* Add tornado WebSocketHandler instrumentation support. (#2761)

* Linting

* Update CHANGELOG.md

* Apply refactor changes from #3582

---------

Co-authored-by: Riccardo Magliocchetti <[email protected]>
devmonkey22 pushed a commit to devmonkey22/opentelemetry-python-contrib that referenced this pull request Aug 5, 2025
…n-telemetry#3582)

* refactor: fix import paths

* fix imports

---------

Co-authored-by: Riccardo Magliocchetti <[email protected]>
devmonkey22 added a commit to devmonkey22/opentelemetry-python-contrib that referenced this pull request Aug 5, 2025
…3498)

* Add tornado WebSocketHandler instrumentation support. (open-telemetry#2761)

* Linting

* Update CHANGELOG.md

* Apply refactor changes from open-telemetry#3582

---------

Co-authored-by: Riccardo Magliocchetti <[email protected]>
sightseeker added a commit to sightseeker/opentelemetry-python-contrib that referenced this pull request Mar 11, 2026
…n-telemetry#3582)

* refactor: fix import paths

* fix imports

---------

Co-authored-by: Riccardo Magliocchetti <[email protected]>
sightseeker added a commit to sightseeker/opentelemetry-python-contrib that referenced this pull request Mar 11, 2026
…3498)

* Add tornado WebSocketHandler instrumentation support. (open-telemetry#2761)

* Linting

* Update CHANGELOG.md

* Apply refactor changes from open-telemetry#3582

---------

Co-authored-by: Riccardo Magliocchetti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants