feat(instrumentation-aiohttp-client): Add support for HTTP metrics#3517
Merged
xrmx merged 11 commits intoopen-telemetry:mainfrom May 27, 2025
Merged
feat(instrumentation-aiohttp-client): Add support for HTTP metrics#3517xrmx merged 11 commits intoopen-telemetry:mainfrom
xrmx merged 11 commits intoopen-telemetry:mainfrom
Conversation
tammy-baylis-swi
approved these changes
May 20, 2025
Contributor
tammy-baylis-swi
left a comment
tammy-baylis-swi
left a comment
There was a problem hiding this comment.
This lgtm; thanks for tests, docstring updates, and consistency with how other instrumentors handle the semconv opt-in.
Would be good to also get other Approver and Maintainer eyes on this.
emdneto
reviewed
May 21, 2025
emdneto
reviewed
May 21, 2025
…rc/opentelemetry/instrumentation/aiohttp_client/__init__.py Co-authored-by: Emídio Neto <[email protected]>
…rc/opentelemetry/instrumentation/aiohttp_client/__init__.py Co-authored-by: Emídio Neto <[email protected]>
…rc/opentelemetry/instrumentation/aiohttp_client/__init__.py Co-authored-by: Emídio Neto <[email protected]>
emdneto
approved these changes
May 23, 2025
emdneto
requested changes
May 23, 2025
Member
Author
@emdneto the attributes were missing in Spans as well, added both |
Member
oh. Awesome! Thank you |
emdneto
approved these changes
May 26, 2025
github-project-automation
Bot
moved this from Ready for review
to Done
in Python PR digest
sightseeker
added a commit
to sightseeker/opentelemetry-python-contrib
that referenced
this pull request
Mar 11, 2026
…pen-telemetry#3517) * Add metrics support * Update instrumentation/opentelemetry-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py Co-authored-by: Emídio Neto <[email protected]> * Update instrumentation/opentelemetry-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py Co-authored-by: Emídio Neto <[email protected]> * Update instrumentation/opentelemetry-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py Co-authored-by: Emídio Neto <[email protected]> * Adding tests, updating changelog * Adding server address and port to both spans and metrics --------- Co-authored-by: Emídio Neto <[email protected]> Co-authored-by: Riccardo Magliocchetti <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for metrics in aiohttp-client instrumentation
Fixes #3516
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.