AWS X-Ray Remote Sampler Part 1 - Initial Classes and Rules Poller Implementation#3366
AWS X-Ray Remote Sampler Part 1 - Initial Classes and Rules Poller Implementation#3366xrmx merged 23 commits intoopen-telemetry:mainfrom
Conversation
|
Question: would it make sense to add this to https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/sdk-extension/opentelemetry-sdk-extension-aws instead of creating a new package? |
|
Yeah that makes sense, I synced with package owner @srprash, there is no concern with moving this Sampler to the SDK Extensions. |
|
@xrmx looking for approval from maintainers, the PR has component owner approval. |
|
@xrmx Since this is a partial implementation, what is a good way to hide this new |
|
@xrmx @srprash Since the sampler is currently partially implemented, I've renamed the 2 X-Ray Sampler classes to be marked as internal for now via the following changes:
When the implementation is complete, I will rename |
|
@xrmx Looking for merge! Planning the submit one more PR after this to complete the implementation. |
github-project-automation
Bot
moved this from Ready for review
to Done
in Python PR digest
…plementation (open-telemetry#3366) * remote sampling - initial classes and rules poller * run generate-workflows and ruff * add component owner for aws sampler, run lint * move sampler into aws sdk-extensions * move sampler tests to trace dir, update otel api/sdk deps, update changelog * move mock_clock into tests dir * update component owners for sdk-extension-aws * ruff and lint * address comments * make sampler implementation internal until completion, update tests to not make http requests * remove use of Optional, restore README of the package * remove unused clock and client_id * Update component_owners.yml * Update CHANGELOG.md --------- Co-authored-by: Riccardo Magliocchetti <[email protected]>
4 participants
Description
This is an initial PR to address #3305 in order for OTel Python to support X-Ray Remote Sampling. A series of PRs to fully implement this feature will follow.
Changes:
opentelemetry-sdk-extension-awsType of change
Please delete options that are not relevant.
How Has This Been Tested?
This PR is not a full implementation of the sampler, so it cannot be tested for correct functionality.
Right now, it currently always return a Parent Based decision or a DROP decision as a placeholder.
A couple more PRs will follow-up to complete the implementation, which should look like this Sampler code from the AWS ADOT repo. At that point in the future, a full E2E integration test will be run.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.