botocore: handle exceptions when consuming streaming versions of bedrock APIs#3211
Merged
xrmx merged 2 commits intoopen-telemetry:mainfrom Jan 28, 2025
Merged
Conversation
18 tasks
xrmx
force-pushed
the
error-handling-for-streaming
branch
2 times, most recently
from
8da2e26 to
5fde615
Compare
xrmx
force-pushed
the
error-handling-for-streaming
branch
from
5fde615 to
388fd0d
Compare
alizenhom
approved these changes
Jan 28, 2025
lmolkova
approved these changes
Jan 28, 2025
Contributor
codefromthecrypt
left a comment
codefromthecrypt
left a comment
There was a problem hiding this comment.
late review I was going to after the other PRs merged, but pleasantly well this is merged before had the change.
👍
I like both the suggestion to to this and also the doing it. Keep up the velocity!
aryabharat
pushed a commit
to aryabharat/opentelemetry-python-contrib
that referenced
this pull request
Feb 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add handling of exceptions when consuming the EventStream for both ConverseStream and InvokeModelWithStreamResponse.
Please note the exception is manually injected and has not been recorded.
Refs #3210
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.