Skip to content

fix: remove opentelemetry-instrumentation-test package from bootstrap_gen#2969

Merged
lzchen merged 6 commits intoopen-telemetry:mainfrom
emdneto:issue2968
Nov 7, 2024
Merged

fix: remove opentelemetry-instrumentation-test package from bootstrap_gen#2969
lzchen merged 6 commits intoopen-telemetry:mainfrom
emdneto:issue2968

Conversation

@emdneto
Copy link
Copy Markdown
Member

@emdneto emdneto commented Nov 7, 2024

Description

Fixes #2968

@emdneto emdneto requested a review from a team as a code owner November 7, 2024 00:23
@rayrapetyan
Copy link
Copy Markdown
Contributor

Please consider adding a version specifier to

first instead of removing opentelemetry-instrumentation-test package.

@xrmx
Copy link
Copy Markdown
Contributor

xrmx commented Nov 7, 2024

Should this be listed as breaking change and write to remove that package to avoid conflicts in CHANGELOG?

@emdneto
Copy link
Copy Markdown
Member Author

emdneto commented Nov 7, 2024

Please consider adding a version specifier to

first instead of removing opentelemetry-instrumentation-test package.

To not mix different things I prefer to fix sqlalchemy issue in another PR.

@emdneto emdneto changed the title remove opentelemetry-instrumentation-test package from bootstrap_gen fix: remove opentelemetry-instrumentation-test package from bootstrap_gen Nov 7, 2024
@emdneto emdneto marked this pull request as draft November 7, 2024 18:14
Signed-off-by: emdneto <[email protected]>
@emdneto emdneto marked this pull request as ready for review November 7, 2024 18:25
@lzchen lzchen merged commit ca4d517 into open-telemetry:main Nov 7, 2024
lmolkova pushed a commit to lmolkova/opentelemetry-python-contrib that referenced this pull request Nov 7, 2024
xrmx pushed a commit to xrmx/opentelemetry-python-contrib that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bootstrap.py fails to install opentelemetry-instrumentation-test==1.0.0b.dev on version 0.49b0

5 participants