Fix issue opentelemetry-instrumentation-asgi: do not set url.full attribute for server spans #2735
Merged
lzchen merged 14 commits intoopen-telemetry:mainfrom Aug 14, 2024
Merged
Conversation
Signed-off-by: Shi, Stone <[email protected]>
Signed-off-by: Shi, Stone <[email protected]>
Signed-off-by: Shi, Stone <[email protected]>
brianwarner
force-pushed
the
fix-jinja2-template
branch
from
b719b22 to
c758f67
Compare
emdneto
reviewed
Jul 30, 2024
Member
emdneto
left a comment
emdneto
left a comment
There was a problem hiding this comment.
Could you please add a Changelog entry for this?
emdneto
reviewed
Jul 30, 2024
Signed-off-by: Shi, Stone <[email protected]>
brianwarner
force-pushed
the
fix-jinja2-template
branch
from
43eeddd to
001165f
Compare
Signed-off-by: Shi, Stone <[email protected]>
Signed-off-by: Shi, Stone <[email protected]>
Signed-off-by: Shi, Stone <[email protected]>
brianwarner
force-pushed
the
fix-jinja2-template
branch
from
f726192 to
3385bb0
Compare
Contributor
Author
|
@emdneto all checks have passed now. Can you take a look when you get a chance? |
emdneto
requested changes
Aug 12, 2024
lzchen
reviewed
Aug 12, 2024
Signed-off-by: Shi, Stone <[email protected]>
brianwarner
force-pushed
the
fix-jinja2-template
branch
from
6e934cb to
14b0bc5
Compare
lzchen
approved these changes
Aug 14, 2024
emdneto
approved these changes
Aug 14, 2024
xrmx
pushed a commit
to xrmx/opentelemetry-python-contrib
that referenced
this pull request
Jan 24, 2025
…ribute for server spans (open-telemetry#2735)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2698
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.