Skip to content

Separate lint into several jobs#2467

Merged
ocelotl merged 69 commits into
open-telemetry:mainfrom
ocelotl:issue_2419
Apr 30, 2024
Merged

Separate lint into several jobs#2467
ocelotl merged 69 commits into
open-telemetry:mainfrom
ocelotl:issue_2419

Conversation

@ocelotl

@ocelotl ocelotl commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

Fixes #2419

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 26, 2024
@ocelotl ocelotl self-assigned this Apr 26, 2024
@ocelotl
ocelotl requested a review from a team April 26, 2024 18:48
@ocelotl
ocelotl marked this pull request as draft April 26, 2024 18:48

@xrmx xrmx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI black, isort and flake8 can be run once per repository instead of per package, that would avoid duplicating a ton of lines in tox (and also work)

@ocelotl
ocelotl force-pushed the issue_2419 branch 3 times, most recently from 1f65939 to 1638399 Compare April 26, 2024 21:57
@ocelotl

ocelotl commented Apr 26, 2024

Copy link
Copy Markdown
Contributor Author

FYI black, isort and flake8 can be run once per repository instead of per package, that would avoid duplicating a ton of lines in tox (and also work)

Sure, but I want to produce a scenario as similar as possible to a scenario where there are multiple tox.ini files, one per package.

@ocelotl
ocelotl marked this pull request as ready for review April 26, 2024 22:45
Comment thread tox.ini
@ocelotl
ocelotl force-pushed the issue_2419 branch 2 times, most recently from a4ea75f to b0e6efc Compare April 27, 2024 22:26
@ocelotl

ocelotl commented Apr 27, 2024

Copy link
Copy Markdown
Contributor Author

@xrmx

xrmx commented Apr 29, 2024

Copy link
Copy Markdown
Contributor

FYI black, isort and flake8 can be run once per repository instead of per package, that would avoid duplicating a ton of lines in tox (and also work)

Sure, but I want to produce a scenario as similar as possible to a scenario where there are multiple tox.ini files, one per package.

I see that, I would had hoped to make lint faster by using faster tools before splitting stuff though.

@ocelotl

ocelotl commented Apr 29, 2024

Copy link
Copy Markdown
Contributor Author

FYI black, isort and flake8 can be run once per repository instead of per package, that would avoid duplicating a ton of lines in tox (and also work)

Sure, but I want to produce a scenario as similar as possible to a scenario where there are multiple tox.ini files, one per package.

I see that, I would had hoped to make lint faster by using faster tools before splitting stuff though.

Sure, we can move to another tool later, this does not introduce anyting new that needs further CI testing and already makes a huge difference.

@ocelotl
ocelotl requested a review from xrmx April 29, 2024 22:40

@xrmx xrmx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to sort packages in the matrix though

@ocelotl

ocelotl commented Apr 30, 2024

Copy link
Copy Markdown
Contributor Author

Would be nice to sort packages in the matrix though

Right, I just sorted them ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Lint is very slow

2 participants