Skip to content

Remove unnecessary package installations#2424

Merged
ocelotl merged 2 commits into
open-telemetry:mainfrom
ocelotl:issue_2423
Apr 25, 2024
Merged

Remove unnecessary package installations#2424
ocelotl merged 2 commits into
open-telemetry:mainfrom
ocelotl:issue_2423

Conversation

@ocelotl

@ocelotl ocelotl commented Apr 15, 2024

Copy link
Copy Markdown
Contributor

Fixes #2423

@ocelotl ocelotl self-assigned this Apr 15, 2024
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 15, 2024
@ocelotl
ocelotl force-pushed the issue_2423 branch 2 times, most recently from be5b603 to b72b5a2 Compare April 15, 2024 21:51
@ocelotl

ocelotl commented Apr 15, 2024

Copy link
Copy Markdown
Contributor Author

This PR adds more code to tox.ini but it now allows us to know exactly what test dependencies each package has. I want to move in a direction where the testing information for each package lives in each package and this is a step in that direction.

kafka, sio-pika and aio-pika do not need test-utils, so that test dependency has been removed from them.

@ocelotl
ocelotl marked this pull request as ready for review April 15, 2024 22:04
@ocelotl
ocelotl requested a review from a team April 15, 2024 22:04

@tammy-baylis-swi tammy-baylis-swi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this is good as a step in reorganization.

Comment thread tox.ini
@lzchen
lzchen marked this pull request as draft April 18, 2024 16:39
@ocelotl
ocelotl marked this pull request as ready for review April 25, 2024 15:58
@ocelotl
ocelotl merged commit bd4a22a into open-telemetry:main Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Do not install unnecessary packages

3 participants