Update README.rst to include disclosure of non-support by Confluent#1731
Closed
yalfah wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
Update README.rst to include disclosure of non-support by Confluent#1731yalfah wants to merge 1 commit intoopen-telemetry:mainfrom
yalfah wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Confluent non-support clarification
|
lzchen
reviewed
Mar 28, 2023
| :target: https://pypi.org/project/opentelemetry-instrumentation-confluent-kafka/ | ||
|
|
||
| This library allows tracing requests made by the confluent-kafka library. | ||
| This library allows tracing requests made by the confluent-kafka library. This OpenTelemetry library is not written or supported by Confluent. |
Contributor
There was a problem hiding this comment.
Curious as to why this needs to be explicitly called out?
Member
There was a problem hiding this comment.
None of the instrumentation here is supported by any of the original authors of the libraries. If we want to call out that, I think it's better to put something generic about the whole contrib repo instrumentations instead of each instrumentation.
Author
There was a problem hiding this comment.
Due to the name of the library some users are under the impression that the library is supported by Confluent, so its best to have something that provides that context to avoid the confusion
Contributor
|
To be superseded by #1858. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confluent non-support clarification
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.