Skip to content

Typo fix: caputre => capture#1108

Merged
srikanthccv merged 2 commits intoopen-telemetry:mainfrom
TBBle:patch-1
May 27, 2022
Merged

Typo fix: caputre => capture#1108
srikanthccv merged 2 commits intoopen-telemetry:mainfrom
TBBle:patch-1

Conversation

@TBBle
Copy link
Copy Markdown
Contributor

@TBBle TBBle commented May 26, 2022

Description

Small repeated/duplicated typo fix, noticed while browsing the codebase.

Type of change

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

@TBBle TBBle requested a review from a team May 26, 2022 14:15
@TBBle
Copy link
Copy Markdown
Contributor Author

TBBle commented May 26, 2022

Erk, I just did a quick search, and the same typo was (I guess) cut-and-paste into multiple projects.

@srikanthccv srikanthccv added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 26, 2022
@TBBle
Copy link
Copy Markdown
Contributor Author

TBBle commented May 26, 2022

Bleh. Build is failing due to the equivalent of open-telemetry/opentelemetry-python#2717 in opentelemetry-instrumentation-grpc due to overly-optimistic protobuf dependency.

I assume the fix for this repo will want to match whatever's done for open-telemetry/opentelemetry-python#2717, whether there's a quick fix to close the dependency against protobuf 4.x, or they go straight to "regenerate the generated files".

Either way, not related to this PR, I believe.

Edit: The problematic package has been yanked, so CI should pass if rerun. I also posted #1109 to fix the issue for when 4.x is unyanked.

@srikanthccv srikanthccv merged commit f7409b8 into open-telemetry:main May 27, 2022
@TBBle TBBle deleted the patch-1 branch May 27, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants